public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Lan Zhu <zhu.lan.cn@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: can we increase the send buffer size of rfcomm socket?
Date: Wed, 26 Aug 2009 11:04:07 -0700	[thread overview]
Message-ID: <1251309847.2950.96.camel@localhost.localdomain> (raw)
In-Reply-To: <113d36d80908260307g59eead24v9311d612c8541ad0@mail.gmail.com>

Hi Zhu,

> We tried to write a 64k data to rfcomm socket, but it will break
> before sending all of the data out. The problem is in function
> rfcomm_sock_sendmsg() in net/bluetooth/rfcomm/sock.c, it breaks after
> calling sock_alloc_send_skb().
> 
> static int rfcomm_sock_sendmsg(...)
> {
>    ...
> 		skb = sock_alloc_send_skb(sk, size + RFCOMM_SKB_RESERVE,
> 				msg->msg_flags & MSG_DONTWAIT, &err);
> 		if (!skb)
> 			break;
>    ...
> }
> 
> Looks the send buffer is not adequate. Then I increased the send
> buffer size in function rfcomm_sock_alloc(),  build kernel and try
> again, this time the sendmsg can complete sending all the data.
> 
> Can we use the setsockopt() method to change the socket's send/receive
> buffer size, just like the usual  tcp/ip socket?

yes we can. Send a patch for it and I am going to review it.

Regards

Marcel



  reply	other threads:[~2009-08-26 18:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-26 10:07 can we increase the send buffer size of rfcomm socket? Lan Zhu
2009-08-26 18:04 ` Marcel Holtmann [this message]
2009-08-27 15:33   ` Lan Zhu
2009-08-27 19:30     ` Marcel Holtmann
2009-08-28  9:34       ` Lan Zhu
2009-08-28 16:58         ` Marcel Holtmann
2009-08-28 17:54           ` Iain Hibbert
2009-08-29 11:19             ` Lan Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1251309847.2950.96.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=zhu.lan.cn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox