From: Marcel Holtmann <marcel@holtmann.org>
To: "Gustavo F. Padovan" <gustavo@las.ic.unicamp.br>
Cc: linux-bluetooth@vger.kernel.org, gustavo@padovan.org
Subject: Re: [PATCH 3/7] Bluetooth: Fix unset of SrejActioned flag
Date: Mon, 28 Sep 2009 21:57:12 -0700 [thread overview]
Message-ID: <1254200232.2659.73.camel@localhost.localdomain> (raw)
In-Reply-To: <1254199349-19713-3-git-send-email-gustavo@las.ic.unicamp.br>
Hi Gustavo,
> pi->conn_state is the right place to set states
>
> Signed-off-by: Gustavo F. Padovan <gustavo@las.ic.unicamp.br>
> ---
> net/bluetooth/l2cap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
> index 3f9d74b..658e27c 100644
> --- a/net/bluetooth/l2cap.c
> +++ b/net/bluetooth/l2cap.c
> @@ -3433,7 +3433,7 @@ static inline int l2cap_data_channel_sframe(struct sock *sk, u16 rx_control, str
> } else if (rx_control & L2CAP_CTRL_FINAL) {
> if ((pi->conn_state & L2CAP_CONN_SREJ_ACT) &&
> pi->srej_save_reqseq == tx_seq)
> - pi->srej_save_reqseq &= ~L2CAP_CONN_SREJ_ACT;
> + pi->conn_state &= ~L2CAP_CONN_SREJ_ACT;
> else
> l2cap_retransmit_frame(sk, tx_seq);
> }
clearly a bug, but the commit message is not enough. Describe it in
plain English and not some cryptic way. The patch is easier to
understand the commit message. It should be the other way around.
Regards
Marcel
next prev parent reply other threads:[~2009-09-29 4:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 4:42 [PATCH 1/7] Bluetooth: Put Basic Mode to be the default when using SOCK_SEQPACKET Gustavo F. Padovan
2009-09-29 4:42 ` [PATCH 2/7] Bluetooth: Initialize variables and timers for both channel's sides Gustavo F. Padovan
2009-09-29 4:42 ` [PATCH 3/7] Bluetooth: Fix unset of SrejActioned flag Gustavo F. Padovan
2009-09-29 4:42 ` [PATCH 4/7] Bluetooth: send ReqSeq on I-frames Gustavo F. Padovan
2009-09-29 4:42 ` [PATCH 5/7] Bluetooth: Implement RejActioned flag Gustavo F. Padovan
2009-09-29 4:42 ` [PATCH 6/7] Bluetooth: Fix ReqSeq value on sending I-frames Gustavo F. Padovan
2009-09-29 4:42 ` [PATCH 7/7] Bluetooth: Send ReqSeq on 'SendRRorRNR' function Gustavo F. Padovan
2009-09-29 5:00 ` Marcel Holtmann
2009-09-29 4:59 ` [PATCH 6/7] Bluetooth: Fix ReqSeq value on sending I-frames Marcel Holtmann
2009-09-29 4:59 ` [PATCH 5/7] Bluetooth: Implement RejActioned flag Marcel Holtmann
2009-09-29 4:58 ` [PATCH 4/7] Bluetooth: send ReqSeq on I-frames Marcel Holtmann
2009-09-29 4:57 ` Marcel Holtmann [this message]
2009-09-29 4:55 ` [PATCH 2/7] Bluetooth: Initialize variables and timers for both channel's sides Marcel Holtmann
2009-09-29 5:15 ` Gustavo F. Padovan
2009-09-29 5:18 ` Marcel Holtmann
2009-09-29 5:00 ` [PATCH 1/7] Bluetooth: Put Basic Mode to be the default when using SOCK_SEQPACKET Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254200232.2659.73.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=gustavo@las.ic.unicamp.br \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox