Re: So very close, but so frustrating...

[Bastien Nocera <hadess@hadess.net>]

On Sat, 2009-10-03 at 01:08 -0700, Dan Williams wrote:
> See the 'btdun' branch of nm-applet, where I've added DUN support to
> the
> gnome-bluetooth plugin.  There's nothing in the applet or NM side yet,
> both will need further fixes.  But the gnome-bt plugin seems to work
> OK
> at the moment.  Bastien, can you sanity check it?  There's a lot of
> async dbus calls going on there between the plugin, Bluez, and MM.
> Needs another set of eyes.
> 
> 8b0ae181efd1e3856851e6a44e16bd51d440d0ce
> c1c13b9dff6772bf13ab6217a2eecb986bd67687 

I'd do:
+ return (get_best_method (bdaddr, uuids) != BT_METHOD_UNKNOWN);
instead of:
+ return !!get_best_method (bdaddr, uuids);

Also, you're inside the wizard (or the properties, once I actually write
that code), so you can remove stuff like:
find_device_cb() and use bluetooth_client_get_model() instead

Something like:
client = bluetooth_client_new ();
model = bluetooth_client_get_model(client);
/* Loop to find the device's proxy object */
g_object_unref (model);
g_object_unref (client);
/* change the interface on the proxy object */

That would remove the need to get the default adapter as well.

You can use lib/test-client to see what the model looks like (adapters
with devices as the children).

The code under:
/* Watch for BT device property changes */
is probably racy-ish. Would need to connect to the properties before
launching the connect

Cheers

_______________________________________________
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list