From: Marcel Holtmann <marcel@holtmann.org>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bluetooth: remove useless variable in virtual hci driver
Date: Sat, 24 Oct 2009 17:41:28 +0900 [thread overview]
Message-ID: <1256373688.7812.4.camel@localhost.localdomain> (raw)
In-Reply-To: <1256340575-19359-1-git-send-email-cascardo@holoscopio.com>
Hi Thadeu,
> Commit ac28494c has removed the option to give a minor number as
> parameter for VHCI driver. Remove the variable used for that parameter.
> Print the error code when registering the device fails, instead of the
> requested minor number (which would always be MISC_DYNAMIC_MINOR).
I see the point in removing the variable. That is clearly a leftover,
but what is the error code printing for? That is pointless since we can
just return misc_register(&vhci_miscdev); since it is the module loading
function. And in the exit module case I don't care. The misc_deregister
should not return an error to begin with. It is pointless. Fix up the
patch and re-sent it.
Regards
Marcel
next prev parent reply other threads:[~2009-10-24 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 23:29 [PATCH] bluetooth: remove useless variable in virtual hci driver Thadeu Lima de Souza Cascardo
2009-10-24 8:41 ` Marcel Holtmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-10-26 15:59 Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256373688.7812.4.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=cascardo@holoscopio.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox