From: Marcel Holtmann <marcel@holtmann.org>
To: Oliver Neukum <oliver@neukum.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, linux-bluetooth@vger.kernel.org
Subject: Re: fix memory leak in fixed btusb_close
Date: Fri, 13 Nov 2009 12:14:59 +0100 [thread overview]
Message-ID: <1258110899.3299.7.camel@violet> (raw)
In-Reply-To: <200911131053.38152.oliver@neukum.org>
Hi Oliver,
> > > If the waker is killed before it can replay outstanding URBs,
> > > these URBs won't be freed or will be replayed at the next open.
> > > This patch closes the window by explicitely discarding outstanding
> > > URBs.
> > >
> > > Signed-off-by: Oliver Neukum <oliver@neukum.org>
> >
> > Acked-by: Marcel Holtmann <marcel@holtmann.org>
> >
> > > Rafael, could you test this just to make sure? I don't want to screw
> > > up the same driver twice.
> >
> > Feel free to send this directly to Linus for inclusion.
>
> This late in the RCs?
he can decide not to take it if chooses, but from my point of view it
worth fixing.
Regards
Marcel
prev parent reply other threads:[~2009-11-13 11:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 15:52 fix memory leak in fixed btusb_close Oliver Neukum
2009-11-12 22:13 ` Rafael J. Wysocki
2009-11-13 3:08 ` Marcel Holtmann
2009-11-13 9:53 ` Oliver Neukum
2009-11-13 11:14 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258110899.3299.7.camel@violet \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox