From: Marcel Holtmann <marcel@holtmann.org>
To: Oliver Neukum <oliver@neukum.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-bluetooth@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch]fix memory leak in fixed btusb_close
Date: Fri, 13 Nov 2009 15:17:19 +0100 [thread overview]
Message-ID: <1258121839.3299.21.camel@violet> (raw)
In-Reply-To: <200911131426.24001.oliver@neukum.org>
Hi Linus,
> If the waker is killed before it can replay outstanding URBs,
> these URBs won't be freed or will be replayed at the next open.
> This patch closes the window by explicitely discarding outstanding
> URBs.
>
> Signed-off-by: Oliver Neukum <oliver@neukum.org>
>
> Linus,
>
> this fixes a memory leak in your fix of btusb.
>
> Regards
> Oliver
>
> --
>
> commit 8a3e793888c75bc7a49ff8b0be7ec6bd5438d985
> Author: Oliver Neukum <oliver@neukum.org>
> Date: Thu Nov 12 16:41:46 2009 +0100
>
> btusb: close race in disconnect leading to a memory leak
>
> if the waker work is cancelled any deferred IO must be discarded
> in close to free the memory and make sure the data isn't replayed
> later
Acked-by: Marcel Holtmann <marcel@holtmann.org>
In case you wanna take it this late. Otherwise let me know and I queue
it up for the next merge window.
Regards
Marcel
prev parent reply other threads:[~2009-11-13 14:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 13:26 [patch]fix memory leak in fixed btusb_close Oliver Neukum
2009-11-13 14:17 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258121839.3299.21.camel@violet \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox