* [PATCH 1/1] Bluetooth: Ack I-frames before retransmit missing packet
@ 2009-12-15 22:13 Gustavo F. Padovan
2009-12-17 20:05 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo F. Padovan @ 2009-12-15 22:13 UTC (permalink / raw)
To: linux-bluetooth; +Cc: marcel, gustavo
Moving the Ack to before l2cap_retransmit_frame() we can avoid the case
where txWindow is full and the packet can't be retransmited.
Signed-off-by: Gustavo F. Padovan <gustavo@las.ic.unicamp.br>
---
net/bluetooth/l2cap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
index 2a2da9d..bb79946 100644
--- a/net/bluetooth/l2cap.c
+++ b/net/bluetooth/l2cap.c
@@ -3505,9 +3505,9 @@ static inline int l2cap_data_channel_sframe(struct sock *sk, u16 rx_control, str
pi->conn_state &= ~L2CAP_CONN_REMOTE_BUSY;
if (rx_control & L2CAP_CTRL_POLL) {
- l2cap_retransmit_frame(sk, tx_seq);
pi->expected_ack_seq = tx_seq;
l2cap_drop_acked_frames(sk);
+ l2cap_retransmit_frame(sk, tx_seq);
l2cap_ertm_send(sk);
if (pi->conn_state & L2CAP_CONN_WAIT_F) {
pi->srej_save_reqseq = tx_seq;
--
1.6.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] Bluetooth: Ack I-frames before retransmit missing packet
2009-12-15 22:13 [PATCH 1/1] Bluetooth: Ack I-frames before retransmit missing packet Gustavo F. Padovan
@ 2009-12-17 20:05 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2009-12-17 20:05 UTC (permalink / raw)
To: Gustavo F. Padovan; +Cc: linux-bluetooth, gustavo
Hi Gustavo,
> Moving the Ack to before l2cap_retransmit_frame() we can avoid the case
> where txWindow is full and the packet can't be retransmited.
patch has been applied. Thanks.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-17 20:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15 22:13 [PATCH 1/1] Bluetooth: Ack I-frames before retransmit missing packet Gustavo F. Padovan
2009-12-17 20:05 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).