[PATCH 1/1] Bluetooth: fix unset of RemoteBusy flag

[PATCH 1/1] Bluetooth: fix unset of RemoteBusy flag

[Gustavo F. Padovan]

RemoteBusy flag need to be unset before l2cap_ertm_send(), otherwise
l2cap_ertm_send() will return without sending packets because it checks
that flag before start sending.

Signed-off-by: Gustavo F. Padovan <gustavo@las.ic.unicamp.br>
---
 net/bluetooth/l2cap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
index 8a2b3d3..2a2da9d 100644
--- a/net/bluetooth/l2cap.c
+++ b/net/bluetooth/l2cap.c
@@ -3469,8 +3469,8 @@ static inline int l2cap_data_channel_sframe(struct sock *sk, u16 rx_control, str
 					&& (pi->unacked_frames > 0))
 				__mod_retrans_timer();
 
-			l2cap_ertm_send(sk);
 			pi->conn_state &= ~L2CAP_CONN_REMOTE_BUSY;
+			l2cap_ertm_send(sk);
 		}
 		break;
 
-- 
1.6.4.4

AW: [PATCH 1/1] Bluetooth: fix unset of RemoteBusy flag

[Marian Harbach]

Hi,

I have the same problem as described in this post:

http://www.spinics.net/lists/linux-bluetooth/msg03627.html

I found that depending on filesize, the original input is delayed by some
bytes (180-260 for 16kHz PCM input) and additionally the first few samples
are overwritten when doing sbcenc followed by sbcdec.

Is there a fix for this issue? 

Cheers
Marian

Re: [PATCH 1/1] Bluetooth: fix unset of RemoteBusy flag

[Gustavo F. Padovan]

Hi Marian,

On Tue, Dec 15, 2009 at 6:58 PM, Marian Harbach
<harbach@mathematik.uni-marburg.de> wrote:
> Hi,
>
> I have the same problem as described in this post:

No, you don't have. This patch is about L2CAP Enhanced Retransmission
Mode and it's not related to the problem you had.

>
> http://www.spinics.net/lists/linux-bluetooth/msg03627.html
>
> I found that depending on filesize, the original input is delayed by some
> bytes (180-260 for 16kHz PCM input) and additionally the first few samples
> are overwritten when doing sbcenc followed by sbcdec.
>
> Is there a fix for this issue?
>
> Cheers
> Marian
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Gustavo F. Padovan
http://padovan.org

Re: [PATCH 1/1] Bluetooth: fix unset of RemoteBusy flag

[Marcel Holtmann]

Hi Gustavo,

> RemoteBusy flag need to be unset before l2cap_ertm_send(), otherwise
> l2cap_ertm_send() will return without sending packets because it checks
> that flag before start sending.

patch has been applied. Thanks.

Regards

Marcel