From: Marcel Holtmann <marcel@holtmann.org>
To: Kandukuri Vikram <vkandukuri@atheros.com>
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
lrodriguez@atheros.com
Subject: Re: [PATCH] DFU Driver for Atheros bluetooth chipset AR3011
Date: Wed, 06 Jan 2010 12:57:56 -0800 [thread overview]
Message-ID: <1262811476.16627.402.camel@localhost.localdomain> (raw)
In-Reply-To: <20100106133415.GC13153@atheros-laptop>
Hi Vikram,
> Signed-off-by: Vikram Kandukuri <vikram.kandukuri@atheros.com>
> Signed-off-by: Alicke Xu <sxu@atheros.com>
> Reviewed-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> drivers/bluetooth/Kconfig | 13 +++-
> drivers/bluetooth/Makefile | 1 +
> drivers/bluetooth/ath3k.c | 187 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 200 insertions(+), 1 deletions(-)
> create mode 100644 drivers/bluetooth/ath3k.c
patch has been applied to my trees.
However I still had to hand edit in various small ares. For example
BT_DBG doesn't require the \n newline. So you have never actually tested
the debug code. Otherwise you would have seen that something is off.
Also there were still a bunch of spaces in the code that I had to fix
manually.
Also I prefer if you a bit more consistent writing "Bluetooth" exactly
this way in comment and descriptions. It is brand name and the writing
is suppose to be consistent.
Regards
Marcel
next prev parent reply other threads:[~2010-01-06 20:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 13:34 [PATCH] DFU Driver for Atheros bluetooth chipset AR3011 Kandukuri Vikram
2010-01-06 20:57 ` Marcel Holtmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-11-24 10:10 Kandukuri Vikram
2009-12-01 11:44 ` Vikram Kandukuri
2009-12-03 17:42 ` Marcel Holtmann
2009-12-30 23:01 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262811476.16627.402.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=vkandukuri@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).