[PATCH] Fix bug on ftp plugin when mimetype exists but is unknown

[PATCH] Fix bug on ftp plugin when mimetype exists but is unknown

[Luiz Augusto von Dentz]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

Hi,

The code was returning FALSE (0) when it should return a posix error thus
causing a unkown mimetype to not be handle by mimetype drivers as it
should.

ps: obexd patch

Regards,

-- 
Luiz Augusto von Dentz
Computer Engineer

[-- Attachment #2: 0001-Fix-bug-on-ftp-plugin-when-mimetype-exists-but-is-un.patch --]
[-- Type: text/x-patch, Size: 893 bytes --]

From 74a67587e3f30788c714582cce8f2f790465261e Mon Sep 17 00:00:00 2001
From: Luiz Augusto Von Dentz <luiz.dentz-von@nokia.com>
Date: Mon, 15 Feb 2010 13:33:06 +0200
Subject: [PATCH] Fix bug on ftp plugin when mimetype exists but is unknown

The code was returning FALSE (0) when it should return a posix error thus
causing a unkown mimetype to not be handle by mimetype drivers as it
should.
---
 plugins/ftp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/ftp.c b/plugins/ftp.c
index f15597e..e0a3b97 100644
--- a/plugins/ftp.c
+++ b/plugins/ftp.c
@@ -155,7 +155,7 @@ static gint get_by_type(struct obex_session *os, gchar *type, size_t *size)
 	if (g_str_equal(type, LST_TYPE))
 		return os_prepare_get(os, os->current_folder, size);
 
-	return FALSE;
+	return -ENOENT;
 }
 
 static gint ftp_prepare_get(struct obex_session *os, gchar *file,
-- 
1.6.3.3

Re: [PATCH] Fix bug on ftp plugin when mimetype exists but is unknown

[Marcel Holtmann]

Hi Luiz,

> The code was returning FALSE (0) when it should return a posix error thus
> causing a unkown mimetype to not be handle by mimetype drivers as it
> should.

patch has been applied. Thanks.

Regards

Marcel