linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Fix signal watch when a service name is given
Date: Tue, 16 Feb 2010 07:37:08 -0800	[thread overview]
Message-ID: <1266334628.8849.5.camel@localhost.localdomain> (raw)
In-Reply-To: <2d5a2c101002160715l7f9a2f07y4a40b19e31fa98b3@mail.gmail.com>

Hi Luiz,

> > This should fix g_dbus_add_signal_watch when a service like org.bluez is given.
> 
> 
> Updating since the last one was broken.

I also think that in check_service() we actually have a missing call to
dbus_pending_unref(). That would cause a memory leak.

Regards

Marcel



  reply	other threads:[~2010-02-16 15:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16 14:59 [PATCH] Fix signal watch when a service name is given Luiz Augusto von Dentz
2010-02-16 15:15 ` Luiz Augusto von Dentz
2010-02-16 15:37   ` Marcel Holtmann [this message]
2010-02-16 15:58     ` Luiz Augusto von Dentz
2010-02-16 16:25       ` Luiz Augusto von Dentz
2010-02-17  0:34       ` Vinicius Gomes
2010-02-17  9:06         ` Luiz Augusto von Dentz
2010-02-17 10:00           ` Marcel Holtmann
2010-02-17 16:08             ` Luiz Augusto von Dentz
2010-02-21 20:41               ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266334628.8849.5.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).