From: Marcel Holtmann <marcel@holtmann.org>
To: Iain Hibbert <plunky@rya-online.net>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] bluez-hcidump fix SDP universal attributes
Date: Tue, 16 Feb 2010 07:42:42 -0800 [thread overview]
Message-ID: <1266334962.8849.8.camel@localhost.localdomain> (raw)
In-Reply-To: <1266312330.230253.2026.nullmailer@galant.ukfsn.org>
Hi Iain,
> > > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > > don't know what Icon_10 was, perhaps an older name?
> > >
> > > Eg, from an SDP probe of a mouse:
> > >
> > > aid 0x000d (IconURL)
> > > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
> >
> > Reposting because there was no response to this, patch is attached..
> >
> > See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> > Attribute" sections in the core specification for reference..
> >
> > (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> > accurate as more than one protocol descriptor list may be included)
>
> posting this simple (and easily verified) patch for hcidump for the third
> time..
sorry for having missed it. For some reason it got sorted away. Can you
create a proper patch with git format-patch. That makes it way easier
for me to apply them.
Regards
Marcel
next prev parent reply other threads:[~2010-02-16 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 19:42 [patch] bluez-hcidump fix SDP universal attributes Iain Hibbert
2010-01-19 11:41 ` Iain Hibbert
2010-02-16 9:25 ` [PATCH] " Iain Hibbert
2010-02-16 15:42 ` Marcel Holtmann [this message]
2010-02-16 22:55 ` Iain Hibbert
2010-02-17 10:02 ` Marcel Holtmann
2010-02-17 10:32 ` Iain Hibbert
2010-02-17 17:19 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266334962.8849.8.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=plunky@rya-online.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).