linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] eSCO fallback to SCO on Error: Unsupported Feature or Parameter Value
@ 2010-02-16 16:29 smcoe
  2010-02-16 18:05 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: smcoe @ 2010-02-16 16:29 UTC (permalink / raw)
  To: marcel; +Cc: linux-bluetooth, Stephen Coe

The Bluetooth SIG PTS test case: TC_AG_ACS_BV_10_I, rejects eSCO with
"Unsupported Feature or Parameter Value" (0x11).  This patch adds case
for SCO fall back.

2007-09-20 12:20:37.787747 > HCI Event: Number of Completed Packets
(0x13) plen 5
   handle 38 packets 1
2007-09-20 12:20:37.842154 < HCI Command: Setup Synchronous Connection
(0x01|0x0028) plen 17
   handle 38 voice setting 0x0060
2007-09-20 12:20:37.847037 > HCI Event: Command Status (0x0f) plen 4
   Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 1
2007-09-20 12:20:37.855233 > HCI Event: Max Slots Change (0x1b) plen 3
   handle 38 slots 1
2007-09-20 12:20:39.913354 > HCI Event: Synchronous Connect Complete
(0x2c) plen 17
   status 0x11 handle 38 bdaddr 00:16:93:01:01:7A type eSCO
   Error: Unsupported Feature or Parameter Value
2007-09-20 12:20:39.922629 > HCI Event: Max Slots Change (0x1b) plen 3
   handle 38 slots 5
2007-09-20 12:20:58.126886 < ACL data: handle 38 flags 0x02 dlen 8
   L2CAP(d): cid 0x0041 len 4 [psm 0]
     0000: 0b 53 01 b8                                       .S..
2007-09-20 12:20:58.130138 > HCI Event: Number of Completed Packets
(0x13) plen 5
   handle 38 packets 1

Signed-off-by: Stephen Coe <smcoe1@gmail.com>
---
 net/bluetooth/hci_event.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 592da5c..6c57fc7 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1698,6 +1698,7 @@ static inline void hci_sync_conn_complete_evt(struct hci_dev *hdev, struct sk_bu
 		hci_conn_add_sysfs(conn);
 		break;
 
+	case 0x11:	/* Unsupported Feature or Parameter Value */
 	case 0x1c:	/* SCO interval rejected */
 	case 0x1a:	/* Unsupported Remote Feature */
 	case 0x1f:	/* Unspecified error */

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] eSCO fallback to SCO on Error: Unsupported Feature or Parameter Value
  2010-02-16 16:29 [PATCH] eSCO fallback to SCO on Error: Unsupported Feature or Parameter Value smcoe
@ 2010-02-16 18:05 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2010-02-16 18:05 UTC (permalink / raw)
  To: smcoe; +Cc: linux-bluetooth, Stephen Coe

Hi Stephen,

> The Bluetooth SIG PTS test case: TC_AG_ACS_BV_10_I, rejects eSCO with
> "Unsupported Feature or Parameter Value" (0x11).  This patch adds case
> for SCO fall back.
> 
> 2007-09-20 12:20:37.787747 > HCI Event: Number of Completed Packets
> (0x13) plen 5
>    handle 38 packets 1
> 2007-09-20 12:20:37.842154 < HCI Command: Setup Synchronous Connection
> (0x01|0x0028) plen 17
>    handle 38 voice setting 0x0060
> 2007-09-20 12:20:37.847037 > HCI Event: Command Status (0x0f) plen 4
>    Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 1
> 2007-09-20 12:20:37.855233 > HCI Event: Max Slots Change (0x1b) plen 3
>    handle 38 slots 1
> 2007-09-20 12:20:39.913354 > HCI Event: Synchronous Connect Complete
> (0x2c) plen 17
>    status 0x11 handle 38 bdaddr 00:16:93:01:01:7A type eSCO
>    Error: Unsupported Feature or Parameter Value
> 2007-09-20 12:20:39.922629 > HCI Event: Max Slots Change (0x1b) plen 3
>    handle 38 slots 5
> 2007-09-20 12:20:58.126886 < ACL data: handle 38 flags 0x02 dlen 8
>    L2CAP(d): cid 0x0041 len 4 [psm 0]
>      0000: 0b 53 01 b8                                       .S..
> 2007-09-20 12:20:58.130138 > HCI Event: Number of Completed Packets
> (0x13) plen 5
>    handle 38 packets 1
> 
> Signed-off-by: Stephen Coe <smcoe1@gmail.com>
> ---
>  net/bluetooth/hci_event.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

patch has been applied to bluetooth-2.6 tree.

Regards

Marcel



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-16 18:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-16 16:29 [PATCH] eSCO fallback to SCO on Error: Unsupported Feature or Parameter Value smcoe
2010-02-16 18:05 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).