* [patch] bluez-hcidump fix SDP universal attributes
@ 2009-11-30 19:42 Iain Hibbert
2010-01-19 11:41 ` Iain Hibbert
0 siblings, 1 reply; 8+ messages in thread
From: Iain Hibbert @ 2009-11-30 19:42 UTC (permalink / raw)
To: linux-bluetooth
Hi,
hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
don't know what Icon_10 was, perhaps an older name?
Eg, from an SDP probe of a mouse:
aid 0x000d (IconURL)
< < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
Anyway, patch below fixes it up. Sorry, I don't have a git here can't
provide a gitpatch atm
regards,
iain
--- parser/sdp.h.orig 2009-11-30 19:29:35.000000000 +0000
+++ parser/sdp.h
@@ -129,8 +129,8 @@
#define SDP_ATTR_ID_BLUETOOTH_PROFILE_DESCRIPTOR_LIST 0x0009
#define SDP_ATTR_ID_DOCUMENTATION_URL 0x000A
#define SDP_ATTR_ID_CLIENT_EXECUTABLE_URL 0x000B
-#define SDP_ATTR_ID_ICON_10 0x000C
-#define SDP_ATTR_ID_ICON_URL 0x000D
+#define SDP_ATTR_ID_ICON_URL 0x000C
+#define SDP_ATTR_ID_ADDITIONAL_PROTOCOL_DESC_LISTS 0x000D
#define SDP_ATTR_ID_SERVICE_NAME 0x0100
#define SDP_ATTR_ID_SERVICE_DESCRIPTION 0x0101
#define SDP_ATTR_ID_PROVIDER_NAME 0x0102
--- parser/sdp.c.orig 2009-11-30 19:29:31.000000000 +0000
+++ parser/sdp.c
@@ -194,8 +194,8 @@ static sdp_attr_id_nam_lookup_table_t sd
{ SDP_ATTR_ID_BLUETOOTH_PROFILE_DESCRIPTOR_LIST, "BTProfileDescList" },
{ SDP_ATTR_ID_DOCUMENTATION_URL, "DocURL" },
{ SDP_ATTR_ID_CLIENT_EXECUTABLE_URL, "ClientExeURL" },
- { SDP_ATTR_ID_ICON_10, "Icon10" },
{ SDP_ATTR_ID_ICON_URL, "IconURL" },
+ { SDP_ATTR_ID_ADDITIONAL_PROTOCOL_DESC_LISTS, "AdditionalProtocolDescLists" },
{ SDP_ATTR_ID_SERVICE_NAME, "SrvName" },
{ SDP_ATTR_ID_SERVICE_DESCRIPTION, "SrvDesc" },
{ SDP_ATTR_ID_PROVIDER_NAME, "ProviderName" },
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] bluez-hcidump fix SDP universal attributes
2009-11-30 19:42 [patch] bluez-hcidump fix SDP universal attributes Iain Hibbert
@ 2010-01-19 11:41 ` Iain Hibbert
2010-02-16 9:25 ` [PATCH] " Iain Hibbert
0 siblings, 1 reply; 8+ messages in thread
From: Iain Hibbert @ 2010-01-19 11:41 UTC (permalink / raw)
To: linux-bluetooth
[-- Attachment #1: Type: TEXT/PLAIN, Size: 766 bytes --]
On Mon, 30 Nov 2009, Iain Hibbert wrote:
> hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> don't know what Icon_10 was, perhaps an older name?
>
> Eg, from an SDP probe of a mouse:
>
> aid 0x000d (IconURL)
> < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
Reposting because there was no response to this, patch is attached..
See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
Attribute" sections in the core specification for reference..
(they sometimes call it AdditionalProtocolDescriptorLists and that is more
accurate as more than one protocol descriptor list may be included)
regards,
iain
[-- Attachment #2: fix SDP universal attributes for bluez-hcidump --]
[-- Type: TEXT/PLAIN, Size: 1570 bytes --]
--- parser/sdp.c.orig 2009-11-30 19:29:31.000000000 +0000
+++ parser/sdp.c
@@ -194,8 +194,8 @@ static sdp_attr_id_nam_lookup_table_t sd
{ SDP_ATTR_ID_BLUETOOTH_PROFILE_DESCRIPTOR_LIST, "BTProfileDescList" },
{ SDP_ATTR_ID_DOCUMENTATION_URL, "DocURL" },
{ SDP_ATTR_ID_CLIENT_EXECUTABLE_URL, "ClientExeURL" },
- { SDP_ATTR_ID_ICON_10, "Icon10" },
{ SDP_ATTR_ID_ICON_URL, "IconURL" },
+ { SDP_ATTR_ID_ADDITIONAL_PROTOCOL_DESC_LISTS, "AdditionalProtocolDescLists" },
{ SDP_ATTR_ID_SERVICE_NAME, "SrvName" },
{ SDP_ATTR_ID_SERVICE_DESCRIPTION, "SrvDesc" },
{ SDP_ATTR_ID_PROVIDER_NAME, "ProviderName" },
--- parser/sdp.h.orig 2009-11-30 19:29:35.000000000 +0000
+++ parser/sdp.h
@@ -129,8 +129,8 @@
#define SDP_ATTR_ID_BLUETOOTH_PROFILE_DESCRIPTOR_LIST 0x0009
#define SDP_ATTR_ID_DOCUMENTATION_URL 0x000A
#define SDP_ATTR_ID_CLIENT_EXECUTABLE_URL 0x000B
-#define SDP_ATTR_ID_ICON_10 0x000C
-#define SDP_ATTR_ID_ICON_URL 0x000D
+#define SDP_ATTR_ID_ICON_URL 0x000C
+#define SDP_ATTR_ID_ADDITIONAL_PROTOCOL_DESC_LISTS 0x000D
#define SDP_ATTR_ID_SERVICE_NAME 0x0100
#define SDP_ATTR_ID_SERVICE_DESCRIPTION 0x0101
#define SDP_ATTR_ID_PROVIDER_NAME 0x0102
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] bluez-hcidump fix SDP universal attributes
2010-01-19 11:41 ` Iain Hibbert
@ 2010-02-16 9:25 ` Iain Hibbert
2010-02-16 15:42 ` Marcel Holtmann
0 siblings, 1 reply; 8+ messages in thread
From: Iain Hibbert @ 2010-02-16 9:25 UTC (permalink / raw)
To: linux-bluetooth
[-- Attachment #1: Type: TEXT/PLAIN, Size: 922 bytes --]
On Tue, 19 Jan 2010, Iain Hibbert wrote:
> On Mon, 30 Nov 2009, Iain Hibbert wrote:
>
> > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > don't know what Icon_10 was, perhaps an older name?
> >
> > Eg, from an SDP probe of a mouse:
> >
> > aid 0x000d (IconURL)
> > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
>
> Reposting because there was no response to this, patch is attached..
>
> See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> Attribute" sections in the core specification for reference..
>
> (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> accurate as more than one protocol descriptor list may be included)
posting this simple (and easily verified) patch for hcidump for the third
time..
regards,
iain
[-- Attachment #2: fix SDP universal attributes --]
[-- Type: TEXT/PLAIN, Size: 1570 bytes --]
--- parser/sdp.c.orig 2009-11-30 19:29:31.000000000 +0000
+++ parser/sdp.c
@@ -194,8 +194,8 @@ static sdp_attr_id_nam_lookup_table_t sd
{ SDP_ATTR_ID_BLUETOOTH_PROFILE_DESCRIPTOR_LIST, "BTProfileDescList" },
{ SDP_ATTR_ID_DOCUMENTATION_URL, "DocURL" },
{ SDP_ATTR_ID_CLIENT_EXECUTABLE_URL, "ClientExeURL" },
- { SDP_ATTR_ID_ICON_10, "Icon10" },
{ SDP_ATTR_ID_ICON_URL, "IconURL" },
+ { SDP_ATTR_ID_ADDITIONAL_PROTOCOL_DESC_LISTS, "AdditionalProtocolDescLists" },
{ SDP_ATTR_ID_SERVICE_NAME, "SrvName" },
{ SDP_ATTR_ID_SERVICE_DESCRIPTION, "SrvDesc" },
{ SDP_ATTR_ID_PROVIDER_NAME, "ProviderName" },
--- parser/sdp.h.orig 2009-11-30 19:29:35.000000000 +0000
+++ parser/sdp.h
@@ -129,8 +129,8 @@
#define SDP_ATTR_ID_BLUETOOTH_PROFILE_DESCRIPTOR_LIST 0x0009
#define SDP_ATTR_ID_DOCUMENTATION_URL 0x000A
#define SDP_ATTR_ID_CLIENT_EXECUTABLE_URL 0x000B
-#define SDP_ATTR_ID_ICON_10 0x000C
-#define SDP_ATTR_ID_ICON_URL 0x000D
+#define SDP_ATTR_ID_ICON_URL 0x000C
+#define SDP_ATTR_ID_ADDITIONAL_PROTOCOL_DESC_LISTS 0x000D
#define SDP_ATTR_ID_SERVICE_NAME 0x0100
#define SDP_ATTR_ID_SERVICE_DESCRIPTION 0x0101
#define SDP_ATTR_ID_PROVIDER_NAME 0x0102
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] bluez-hcidump fix SDP universal attributes
2010-02-16 9:25 ` [PATCH] " Iain Hibbert
@ 2010-02-16 15:42 ` Marcel Holtmann
2010-02-16 22:55 ` Iain Hibbert
0 siblings, 1 reply; 8+ messages in thread
From: Marcel Holtmann @ 2010-02-16 15:42 UTC (permalink / raw)
To: Iain Hibbert; +Cc: linux-bluetooth
Hi Iain,
> > > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > > don't know what Icon_10 was, perhaps an older name?
> > >
> > > Eg, from an SDP probe of a mouse:
> > >
> > > aid 0x000d (IconURL)
> > > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
> >
> > Reposting because there was no response to this, patch is attached..
> >
> > See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> > Attribute" sections in the core specification for reference..
> >
> > (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> > accurate as more than one protocol descriptor list may be included)
>
> posting this simple (and easily verified) patch for hcidump for the third
> time..
sorry for having missed it. For some reason it got sorted away. Can you
create a proper patch with git format-patch. That makes it way easier
for me to apply them.
Regards
Marcel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] bluez-hcidump fix SDP universal attributes
2010-02-16 15:42 ` Marcel Holtmann
@ 2010-02-16 22:55 ` Iain Hibbert
2010-02-17 10:02 ` Marcel Holtmann
0 siblings, 1 reply; 8+ messages in thread
From: Iain Hibbert @ 2010-02-16 22:55 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-bluetooth
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1177 bytes --]
On Tue, 16 Feb 2010, Marcel Holtmann wrote:
> > > > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > > > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > > > don't know what Icon_10 was, perhaps an older name?
> > > >
> > > > Eg, from an SDP probe of a mouse:
> > > >
> > > > aid 0x000d (IconURL)
> > > > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
> > >
> > > Reposting because there was no response to this, patch is attached..
> > >
> > > See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> > > Attribute" sections in the core specification for reference..
> > >
> > > (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> > > accurate as more than one protocol descriptor list may be included)
> >
> > posting this simple (and easily verified) patch for hcidump for the third
> > time..
>
> sorry for having missed it. For some reason it got sorted away. Can you
> create a proper patch with git format-patch. That makes it way easier
> for me to apply them.
I am not a git user but perhaps this is correct?
regards,
iain
[-- Attachment #2: git format-patch --]
[-- Type: TEXT/PLAIN, Size: 2087 bytes --]
From 5615f136fb57a97da15a29c8b27cef1a707efaa3 Mon Sep 17 00:00:00 2001
From: Iain Hibbert <plunky@galant.(none)>
Date: Tue, 16 Feb 2010 22:47:19 +0000
Subject: [PATCH] correct SDP Universal Attribute name printing
0x000c = IconURL
0x000d = AttributeProtocolDescriptorLists
---
parser/sdp.c | 2 +-
parser/sdp.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/parser/sdp.c b/parser/sdp.c
index 5f2c1c6..b9f990e 100644
--- a/parser/sdp.c
+++ b/parser/sdp.c
@@ -194,8 +194,8 @@ static sdp_attr_id_nam_lookup_table_t sdp_attr_id_nam_lookup_table[] = {
{ SDP_ATTR_ID_BLUETOOTH_PROFILE_DESCRIPTOR_LIST, "BTProfileDescList" },
{ SDP_ATTR_ID_DOCUMENTATION_URL, "DocURL" },
{ SDP_ATTR_ID_CLIENT_EXECUTABLE_URL, "ClientExeURL" },
- { SDP_ATTR_ID_ICON_10, "Icon10" },
{ SDP_ATTR_ID_ICON_URL, "IconURL" },
+ { SDP_ATTR_ID_ADDITIONAL_PROTOCOL_DESC_LISTS, "AdditionalProtocolDescLists" },
{ SDP_ATTR_ID_SERVICE_NAME, "SrvName" },
{ SDP_ATTR_ID_SERVICE_DESCRIPTION, "SrvDesc" },
{ SDP_ATTR_ID_PROVIDER_NAME, "ProviderName" },
diff --git a/parser/sdp.h b/parser/sdp.h
index 09e4432..4769fd0 100644
--- a/parser/sdp.h
+++ b/parser/sdp.h
@@ -129,8 +129,8 @@
#define SDP_ATTR_ID_BLUETOOTH_PROFILE_DESCRIPTOR_LIST 0x0009
#define SDP_ATTR_ID_DOCUMENTATION_URL 0x000A
#define SDP_ATTR_ID_CLIENT_EXECUTABLE_URL 0x000B
-#define SDP_ATTR_ID_ICON_10 0x000C
-#define SDP_ATTR_ID_ICON_URL 0x000D
+#define SDP_ATTR_ID_ICON_URL 0x000C
+#define SDP_ATTR_ID_ADDITIONAL_PROTOCOL_DESC_LISTS 0x000D
#define SDP_ATTR_ID_SERVICE_NAME 0x0100
#define SDP_ATTR_ID_SERVICE_DESCRIPTION 0x0101
#define SDP_ATTR_ID_PROVIDER_NAME 0x0102
--
1.6.6
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] bluez-hcidump fix SDP universal attributes
2010-02-16 22:55 ` Iain Hibbert
@ 2010-02-17 10:02 ` Marcel Holtmann
2010-02-17 10:32 ` Iain Hibbert
0 siblings, 1 reply; 8+ messages in thread
From: Marcel Holtmann @ 2010-02-17 10:02 UTC (permalink / raw)
To: Iain Hibbert; +Cc: linux-bluetooth
Hi Iain,
> > > > > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > > > > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > > > > don't know what Icon_10 was, perhaps an older name?
> > > > >
> > > > > Eg, from an SDP probe of a mouse:
> > > > >
> > > > > aid 0x000d (IconURL)
> > > > > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
> > > >
> > > > Reposting because there was no response to this, patch is attached..
> > > >
> > > > See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> > > > Attribute" sections in the core specification for reference..
> > > >
> > > > (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> > > > accurate as more than one protocol descriptor list may be included)
> > >
> > > posting this simple (and easily verified) patch for hcidump for the third
> > > time..
> >
> > sorry for having missed it. For some reason it got sorted away. Can you
> > create a proper patch with git format-patch. That makes it way easier
> > for me to apply them.
>
> I am not a git user but perhaps this is correct?
almost, but you need to edit your .gitconfig to create a proper author
name and more specific author email entry.
Regards
Marcel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] bluez-hcidump fix SDP universal attributes
2010-02-17 10:02 ` Marcel Holtmann
@ 2010-02-17 10:32 ` Iain Hibbert
2010-02-17 17:19 ` Marcel Holtmann
0 siblings, 1 reply; 8+ messages in thread
From: Iain Hibbert @ 2010-02-17 10:32 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-bluetooth
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1567 bytes --]
On Wed, 17 Feb 2010, Marcel Holtmann wrote:
> Hi Iain,
>
> > > > > > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > > > > > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > > > > > don't know what Icon_10 was, perhaps an older name?
> > > > > >
> > > > > > Eg, from an SDP probe of a mouse:
> > > > > >
> > > > > > aid 0x000d (IconURL)
> > > > > > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
> > > > >
> > > > > Reposting because there was no response to this, patch is attached..
> > > > >
> > > > > See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> > > > > Attribute" sections in the core specification for reference..
> > > > >
> > > > > (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> > > > > accurate as more than one protocol descriptor list may be included)
> > > >
> > > > posting this simple (and easily verified) patch for hcidump for the third
> > > > time..
> > >
> > > sorry for having missed it. For some reason it got sorted away. Can you
> > > create a proper patch with git format-patch. That makes it way easier
> > > for me to apply them.
> >
> > I am not a git user but perhaps this is correct?
>
> almost, but you need to edit your .gitconfig to create a proper author
> name and more specific author email entry.
Perhaps this is finally correct, but you discourage contributions by being
so restrictive in accepting submissions. Also, you really do need a bug
tracker.
regards,
iain
[-- Attachment #2: Type: TEXT/PLAIN, Size: 2093 bytes --]
From 4c385a2ee6cd49aeaa5e50d0d425379d929624d0 Mon Sep 17 00:00:00 2001
From: Iain Hibbert <plunky@rya-online.net>
Date: Wed, 17 Feb 2010 10:26:04 +0000
Subject: [PATCH] correct SDP Universal Attribute name printing
0x000c = Icon URL
0x000d = Additional Protocol Descriptor Lists
---
parser/sdp.c | 2 +-
parser/sdp.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/parser/sdp.c b/parser/sdp.c
index 5f2c1c6..b9f990e 100644
--- a/parser/sdp.c
+++ b/parser/sdp.c
@@ -194,8 +194,8 @@ static sdp_attr_id_nam_lookup_table_t sdp_attr_id_nam_lookup_table[] = {
{ SDP_ATTR_ID_BLUETOOTH_PROFILE_DESCRIPTOR_LIST, "BTProfileDescList" },
{ SDP_ATTR_ID_DOCUMENTATION_URL, "DocURL" },
{ SDP_ATTR_ID_CLIENT_EXECUTABLE_URL, "ClientExeURL" },
- { SDP_ATTR_ID_ICON_10, "Icon10" },
{ SDP_ATTR_ID_ICON_URL, "IconURL" },
+ { SDP_ATTR_ID_ADDITIONAL_PROTOCOL_DESC_LISTS, "AdditionalProtocolDescLists" },
{ SDP_ATTR_ID_SERVICE_NAME, "SrvName" },
{ SDP_ATTR_ID_SERVICE_DESCRIPTION, "SrvDesc" },
{ SDP_ATTR_ID_PROVIDER_NAME, "ProviderName" },
diff --git a/parser/sdp.h b/parser/sdp.h
index 09e4432..4769fd0 100644
--- a/parser/sdp.h
+++ b/parser/sdp.h
@@ -129,8 +129,8 @@
#define SDP_ATTR_ID_BLUETOOTH_PROFILE_DESCRIPTOR_LIST 0x0009
#define SDP_ATTR_ID_DOCUMENTATION_URL 0x000A
#define SDP_ATTR_ID_CLIENT_EXECUTABLE_URL 0x000B
-#define SDP_ATTR_ID_ICON_10 0x000C
-#define SDP_ATTR_ID_ICON_URL 0x000D
+#define SDP_ATTR_ID_ICON_URL 0x000C
+#define SDP_ATTR_ID_ADDITIONAL_PROTOCOL_DESC_LISTS 0x000D
#define SDP_ATTR_ID_SERVICE_NAME 0x0100
#define SDP_ATTR_ID_SERVICE_DESCRIPTION 0x0101
#define SDP_ATTR_ID_PROVIDER_NAME 0x0102
--
1.6.6
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] bluez-hcidump fix SDP universal attributes
2010-02-17 10:32 ` Iain Hibbert
@ 2010-02-17 17:19 ` Marcel Holtmann
0 siblings, 0 replies; 8+ messages in thread
From: Marcel Holtmann @ 2010-02-17 17:19 UTC (permalink / raw)
To: Iain Hibbert; +Cc: linux-bluetooth
Hi Iain,
> > > > > > > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > > > > > > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > > > > > > don't know what Icon_10 was, perhaps an older name?
> > > > > > >
> > > > > > > Eg, from an SDP probe of a mouse:
> > > > > > >
> > > > > > > aid 0x000d (IconURL)
> > > > > > > < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
> > > > > >
> > > > > > Reposting because there was no response to this, patch is attached..
> > > > > >
> > > > > > See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> > > > > > Attribute" sections in the core specification for reference..
> > > > > >
> > > > > > (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> > > > > > accurate as more than one protocol descriptor list may be included)
> > > > >
> > > > > posting this simple (and easily verified) patch for hcidump for the third
> > > > > time..
> > > >
> > > > sorry for having missed it. For some reason it got sorted away. Can you
> > > > create a proper patch with git format-patch. That makes it way easier
> > > > for me to apply them.
> > >
> > > I am not a git user but perhaps this is correct?
> >
> > almost, but you need to edit your .gitconfig to create a proper author
> > name and more specific author email entry.
>
> Perhaps this is finally correct, but you discourage contributions by being
> so restrictive in accepting submissions. Also, you really do need a bug
> tracker.
patch has been applied. Thanks.
And if I am not restrictive with the patch submission, then I am always
going to clean up after them. Not really something I plan to do.
Regards
Marcel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-02-17 17:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-30 19:42 [patch] bluez-hcidump fix SDP universal attributes Iain Hibbert
2010-01-19 11:41 ` Iain Hibbert
2010-02-16 9:25 ` [PATCH] " Iain Hibbert
2010-02-16 15:42 ` Marcel Holtmann
2010-02-16 22:55 ` Iain Hibbert
2010-02-17 10:02 ` Marcel Holtmann
2010-02-17 10:32 ` Iain Hibbert
2010-02-17 17:19 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).