Re: [PATCH] bluez-hcidump fix SDP universal attributes

[Marcel Holtmann <marcel@holtmann.org>]

Hi Iain,

> > > > > > > hcidump shows SDP universal attribute 0x000d as IconURL but in fact it is
> > > > > > > defined as "Additional Protocol Descriptor Lists". IconURL is 0x000c and I
> > > > > > > don't know what Icon_10 was, perhaps an older name?
> > > > > > >
> > > > > > > Eg, from an SDP probe of a mouse:
> > > > > > >
> > > > > > >       aid 0x000d (IconURL)
> > > > > > >          < < < uuid-16 0x0100 (L2CAP) uint 0x13 > < uuid-16 0x0011 (HIDP) > > >
> > > > > >
> > > > > > Reposting because there was no response to this, patch is attached..
> > > > > >
> > > > > > See "5.1.6 AdditionalProtocolDescriptorList attribute" and "5.1.14 IconURL
> > > > > > Attribute" sections in the core specification for reference..
> > > > > >
> > > > > > (they sometimes call it AdditionalProtocolDescriptorLists and that is more
> > > > > > accurate as more than one protocol descriptor list may be included)
> > > > >
> > > > > posting this simple (and easily verified) patch for hcidump for the third
> > > > > time..
> > > >
> > > > sorry for having missed it. For some reason it got sorted away. Can you
> > > > create a proper patch with git format-patch. That makes it way easier
> > > > for me to apply them.
> > >
> > > I am not a git user but perhaps this is correct?
> >
> > almost, but you need to edit your .gitconfig to create a proper author
> > name and more specific author email entry.
> 
> Perhaps this is finally correct, but you discourage contributions by being
> so restrictive in accepting submissions.  Also, you really do need a bug
> tracker.

patch has been applied. Thanks.

And if I am not restrictive with the patch submission, then I am always
going to clean up after them. Not really something I plan to do.

Regards

Marcel