From: Marcel Holtmann <marcel@holtmann.org>
To: Iain Hibbert <plunky@rya-online.net>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] prevent buffer overruns when parsing invalid OBEX frames
Date: Wed, 17 Feb 2010 11:15:16 -0800 [thread overview]
Message-ID: <1266434116.8849.67.camel@localhost.localdomain> (raw)
In-Reply-To: <1266433932.690365.3132.nullmailer@galant.ukfsn.org>
Hi Iain,
> While I have git installed then, I found a problem recently where hcidump
> would dump core when parsing an OBEX packet. It turned out that the OBEX
> packet was faulty at my end (socket buffer exhausted), but the patch
> attached prevents the parsing code from running off the end of the buffer
> and receiving a SIGSEGV.
>
> The patch does not make any complaint about the invalid frame, adding that
> would be a little more complex and I'm not sure its necessary?
patch has been applied. Thanks.
Regards
Marcel
prev parent reply other threads:[~2010-02-17 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 19:12 [PATCH] prevent buffer overruns when parsing invalid OBEX frames Iain Hibbert
2010-02-17 19:15 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266434116.8849.67.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=plunky@rya-online.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).