public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: Vinicius Gomes <vinicius.gomes@openbossa.org>
Cc: Ed Tsang <netdesign_98@yahoo.com>,
	Bluettooth Linux <linux-bluetooth@vger.kernel.org>
Subject: Re: obexd 0.14 "put" file corruption
Date: Mon, 08 Mar 2010 14:31:41 +0000	[thread overview]
Message-ID: <1268058702.22567.160.camel@localhost.localdomain> (raw)
In-Reply-To: <2a9506371003051238r3be587e2s2681fab9f459a5c9@mail.gmail.com>

On Fri, 2010-03-05 at 17:38 -0300, Vinicius Gomes wrote:
> Hi Ed,
> 
> On Fri, Mar 5, 2010 at 4:51 PM, Ed Tsang <netdesign_98@yahoo.com> wrote:
> > Vinicius,
> >>  Care to send a patch against the current git?
> >
> >   I love to, but I don't know how to generate the patch and setup git?.
> >
> >  The delta is  on  client/session.c   put_xfer_progerss(..)
> > - memmove(session->buffer + written, session->buffer, session->filled);
> > + memmove(session->buffer, session->buffer + written,  session->filled);
> >
> > Could you help me put it into the source.
> > If you are kind enough to point me a link to setup the git and generate a patch, I could be ready next time.
> >
> 
> Sure, just asked for this patch to be included.

You could at least have mentioned Ed's name in the commit log, or
attributed the patch to him...

> Here[1][2][3] are some references to get you started.




  reply	other threads:[~2010-03-08 14:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24 22:23 obexd 0.14 "put" file corruption Ed Tsang
2010-02-26  8:41 ` Luiz Augusto von Dentz
2010-03-05 16:31   ` Bastien Nocera
2010-03-05 18:07     ` Ed Tsang
2010-03-05 19:35       ` Vinicius Gomes
2010-03-05 19:51         ` Ed Tsang
2010-03-05 20:38           ` Vinicius Gomes
2010-03-08 14:31             ` Bastien Nocera [this message]
2010-03-08 16:53               ` Ed Tsang
  -- strict thread matches above, loose matches on Subject: below --
2010-02-24 21:50 Ed Tsang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268058702.22567.160.camel@localhost.localdomain \
    --to=hadess@hadess.net \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=netdesign_98@yahoo.com \
    --cc=vinicius.gomes@openbossa.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox