linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: linux-bluetooth@vger.kernel.org, guy.cohen@intel.com,
	ron.rindjunsky@intel.com,
	Gregory Paskar <gregory.paskar@intel.com>
Subject: Re: [bluetooth-next V2] Bluetooth: handle device reset event
Date: Mon, 08 Mar 2010 17:03:07 -0800	[thread overview]
Message-ID: <1268096587.3712.36.camel@localhost.localdomain> (raw)
In-Reply-To: <1266843933-28802-1-git-send-email-tomas.winkler@intel.com>

Hi Tomas,

> A Bluetooth device experiencing hardware failure may issue
> a HARDWARE_ERROR hci event. The reaction to this event is device
> reset flow implemented in following sequence.
> 
> 1. Notify: HCI_DEV_DOWN
> 2. Reinitialize internal structures.
> 3. Call driver flush function
> 4. Send HCI reset request to the device.
> 5. Send HCI init sequence reset to the device.
> 6. Notify HCI_DEV_UP.

I prefer if we create a generic per controller workqueue first before
having a workqueue for every task. Something similar to what the
mac80211 layer offers right now.

Also in a second step we might wanna move the HCI event processing
completely into a workqueue. If we get no performance hit with that,
then sysfs handling and device reset becomes a lot simpler and less
prone to race conditions with device removal.

Regards

Marcel



  parent reply	other threads:[~2010-03-09  1:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-22 13:05 [bluetooth-next V2] Bluetooth: handle device reset event Tomas Winkler
2010-02-22 13:05 ` [bluetooth-next] bluetooth: hci_sysfs: use strict_strtoul instead of simple_strtoul Tomas Winkler
2010-03-09  1:03   ` Marcel Holtmann
2010-03-09  1:14     ` Winkler, Tomas
2010-03-09  2:16       ` Marcel Holtmann
2010-03-09  1:03 ` Marcel Holtmann [this message]
2010-03-09 21:22   ` [bluetooth-next V2] Bluetooth: handle device reset event Winkler, Tomas
2010-03-10 16:49     ` Marcel Holtmann
2010-03-10 19:35       ` Winkler, Tomas
2010-03-15 19:57         ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268096587.3712.36.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=gregory.paskar@intel.com \
    --cc=guy.cohen@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=ron.rindjunsky@intel.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).