From: Marcel Holtmann <marcel@holtmann.org>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"Cohen, Guy" <guy.cohen@intel.com>,
"Rindjunsky, Ron" <ron.rindjunsky@intel.com>
Subject: RE: [bluetooth-next] bluetooth: hci_sysfs: use strict_strtoul instead of simple_strtoul
Date: Mon, 08 Mar 2010 18:16:35 -0800 [thread overview]
Message-ID: <1268100995.3712.39.camel@localhost.localdomain> (raw)
In-Reply-To: <6F5C1D715B2DA5498A628E6B9C124F04016C0E8D6B@hasmsx504.ger.corp.intel.com>
Hi Tomas,
> > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > > ---
> > > net/bluetooth/hci_sysfs.c | 24 ++++++++++++------------
> > > 1 files changed, 12 insertions(+), 12 deletions(-)
> >
> > can you please explain the rational behind this change. What is the
> > benefit? I just fail to see it right away.
>
> The real reason using strict instead of simple strtoul is explained here thttp://www.kernel.org/doc/htmldocs/kernel-api/re42.html
> In the bottom line it just something a chackpatch is complain about. I've touched the file to insert some test hook for the HCI reset so I fixed that on the way.
I am fine with that. However please use the following constructs:
if (strict_strtoul(...) < 0)
return -EINVAL;
There is no point in having ret variable if you don't use it.
Also I like to have a commit body and not only a subject line. It
doesn't have to be a novel, but only the subject is not good enough for
me.
Regards
Marcel
next prev parent reply other threads:[~2010-03-09 2:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 13:05 [bluetooth-next V2] Bluetooth: handle device reset event Tomas Winkler
2010-02-22 13:05 ` [bluetooth-next] bluetooth: hci_sysfs: use strict_strtoul instead of simple_strtoul Tomas Winkler
2010-03-09 1:03 ` Marcel Holtmann
2010-03-09 1:14 ` Winkler, Tomas
2010-03-09 2:16 ` Marcel Holtmann [this message]
2010-03-09 1:03 ` [bluetooth-next V2] Bluetooth: handle device reset event Marcel Holtmann
2010-03-09 21:22 ` Winkler, Tomas
2010-03-10 16:49 ` Marcel Holtmann
2010-03-10 19:35 ` Winkler, Tomas
2010-03-15 19:57 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268100995.3712.39.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=guy.cohen@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ron.rindjunsky@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).