From: Marcel Holtmann <marcel@holtmann.org>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"Cohen, Guy" <guy.cohen@intel.com>,
"Rindjunsky, Ron" <ron.rindjunsky@intel.com>
Subject: RE: [bluetooth-next V2] bluetooth: hci_sysfs: use strict_strtoul instead of simple_strtoul
Date: Thu, 11 Mar 2010 16:28:51 -0800 [thread overview]
Message-ID: <1268353731.3712.93.camel@localhost.localdomain> (raw)
In-Reply-To: <6F5C1D715B2DA5498A628E6B9C124F04016C0E9798@hasmsx504.ger.corp.intel.com>
Hi Tomas,
> > > use strict_strtoul as suggested by checkpatch.pl
> > >
> > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > > ---
> > > V2:
> > > 1. more verbose commit message
> > > 2. return the error code that was produced by strict_strtoul
> >
> > why do you bother actually. Reading the comment about struct_strtoul it
> > will only return -EINVAL or 0. So using my proposal would be just fine.
> > I also don't prefer to differ the return value to user space until it
> > actually makes sense. Invalid argument is just fine for all error cases.
> >
> Yes I know but I've use of this over the kernel code and what I've used is the mostly used idiom
I choose to have it as I originally proposed. Patch has been pushed into
bluetooth-testing tree.
Regards
Marcel
prev parent reply other threads:[~2010-03-12 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 19:38 [bluetooth-next V2] bluetooth: hci_sysfs: use strict_strtoul instead of simple_strtoul Tomas Winkler
2010-03-09 20:41 ` Marcel Holtmann
2010-03-09 21:13 ` Winkler, Tomas
2010-03-12 0:28 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268353731.3712.93.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=guy.cohen@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ron.rindjunsky@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).