public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Dons Tychsen <donpedro@tdcadsl.dk>
To: linux-bluetooth@vger.kernel.org
Subject: HCI_MAX_DEV is a bit too small.
Date: Mon, 15 Mar 2010 00:20:37 +0100	[thread overview]
Message-ID: <1268608837.6400.26.camel@donpedro> (raw)

Hello,

HCI_MAX_DEV is set a bit low (16), causing hci_for_each_dev() to not
return all of the devices if you have more. This is not a disaster for
the library itself, as i can just copy hci_for_each_dev() and make a
version supporting more devices.

However, hcitool uses the library version of hci_for_each_dev(), so that
makes hcitool useless for a system with more devices. You could of
course fix this is hcitool, but changing HCI_MAX_DEV seem like the right
solution.

Can this be changed, or does it *need* to be 16?

If changed, it would be nice if it was raised to something like 256, to
keep the number in the power of 2. To be honest, i don't think this
should have been a constant at all, as the number of devices is
virtually endless. hci_for_each_dev() should probably have taken a MAX
parameter, but should not itself have set a limit. But to keep the API
intact, changing HCI_MAX_DEV could be a solution. 

Thanks,

/Pedro



             reply	other threads:[~2010-03-14 23:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-14 23:20 Peter Dons Tychsen [this message]
2010-03-14 23:34 ` HCI_MAX_DEV is a bit too small Marcel Holtmann
2010-03-15  2:11   ` Peter Dons Tychsen
2010-03-15  8:34     ` Iain Hibbert
2010-03-21 22:26     ` Peter Dons Tychsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268608837.6400.26.camel@donpedro \
    --to=donpedro@tdcadsl.dk \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox