From: Przemo Firszt <przemo@firszt.eu>
To: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
Bastien Nocera <hadess@hadess.net>, marcel <marcel@holtmann.org>,
Peter Hutterer <peter.hutterer@who-t.net>,
Ping <pinglinux@gmail.com>, Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH 2/2] Add sysfs speed attribute for wacom bluetooth tablet
Date: Thu, 18 Mar 2010 15:26:55 +0000 [thread overview]
Message-ID: <1268926015.12672.27.camel@pldmachine> (raw)
In-Reply-To: <1268925902.12672.25.camel@pldmachine>
[-- Attachment #1: Type: text/plain, Size: 21 bytes --]
Patch 2/2
--
Przemo
[-- Attachment #2: 0002-Add-sysfs-speed-attribute-for-wacom-bluetooth-tablet.patch --]
[-- Type: text/x-patch, Size: 2735 bytes --]
>From 92b0a06c748ea0a853c369595444dd411b32f314 Mon Sep 17 00:00:00 2001
From: Przemo Firszt <przemo@firszt.eu>
Date: Thu, 18 Mar 2010 14:34:34 +0000
Subject: [PATCH 2/2] Add sysfs speed attribute for wacom bluetooth tablet
The attribute allows to change reporting speed of tablet from userspace through
sysfs file. The attribute is RW, valid values: 0 is low speed, 1 is high speed.
High speed is the default setting. Using low speed is a workaround if you
experience lag when using the tablet.
Signed-off-by: Przemo Firszt <przemo@firszt.eu>
---
drivers/hid/hid-wacom.c | 38 +++++++++++++++++++++++++++++++++++++-
1 files changed, 37 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
index f9d4939..34d96e0 100644
--- a/drivers/hid/hid-wacom.c
+++ b/drivers/hid/hid-wacom.c
@@ -30,6 +30,7 @@
struct wacom_data {
__u16 tool;
unsigned char butstate;
+ unsigned char speed;
#ifdef CONFIG_HID_WACOM_POWER_SUPPLY
int battery_capacity;
struct power_supply battery;
@@ -105,6 +106,7 @@ static int wacom_ac_get_property(struct power_supply *psy,
static void wacom_poke(struct hid_device *hdev, u8 speed)
{
+ struct wacom_data *wdata = hid_get_drvdata(hdev);
int limit, ret;
char rep_data[2];
@@ -128,8 +130,10 @@ static void wacom_poke(struct hid_device *hdev, u8 speed)
HID_FEATURE_REPORT);
} while (ret < 0 && limit-- > 0);
- if (ret >= 0)
+ if (ret >= 0) {
+ wdata->speed = speed;
return;
+ }
}
/*
@@ -141,6 +145,33 @@ static void wacom_poke(struct hid_device *hdev, u8 speed)
return;
}
+static ssize_t wacom_show_speed(struct device *dev,
+ struct device_attribute
+ *attr, char *buf)
+{
+ struct wacom_data *wdata = dev_get_drvdata(dev);
+
+ return snprintf(buf, PAGE_SIZE, "%i\n", wdata->speed);
+}
+
+static ssize_t wacom_store_speed(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ struct hid_device *hdev = container_of(dev, struct hid_device, dev);
+ int new_speed;
+
+ sscanf(buf, "%1d", &new_speed);
+ if (new_speed == 0 || new_speed == 1) {
+ wacom_poke(hdev, new_speed);
+ return strnlen(buf, PAGE_SIZE);
+ } else
+ return -EINVAL;
+}
+
+static DEVICE_ATTR(speed, S_IRUGO | S_IWUGO,
+ wacom_show_speed, wacom_store_speed);
+
static int wacom_raw_event(struct hid_device *hdev, struct hid_report *report,
u8 *raw_data, int size)
{
@@ -297,6 +328,11 @@ static int wacom_probe(struct hid_device *hdev,
goto err_free;
}
+ ret = device_create_file(&hdev->dev, &dev_attr_speed);
+ if (ret)
+ dev_warn(&hdev->dev,
+ "can't create sysfs speed attribute err: %d\n", ret);
+
/* Set Wacom mode 2 with high reporting speed */
wacom_poke(hdev, 1);
--
1.7.0.1
next prev parent reply other threads:[~2010-03-18 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 15:25 [PATCH 1/2] Add separate mode switching function wacom bluetooth pen tablet Przemo Firszt
2010-03-18 15:26 ` Przemo Firszt [this message]
2010-03-18 15:37 ` [PATCH 2/2] Add sysfs speed attribute for wacom bluetooth tablet Bastien Nocera
2010-03-18 19:12 ` Przemo Firszt
2010-03-22 8:48 ` Jiri Kosina
2010-04-22 19:51 ` Przemo Firszt
2010-04-23 0:16 ` Jiri Kosina
2010-03-18 15:39 ` [PATCH 1/2] Add separate mode switching function wacom bluetooth pen tablet Bastien Nocera
2010-03-22 8:47 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268926015.12672.27.camel@pldmachine \
--to=przemo@firszt.eu \
--cc=hadess@hadess.net \
--cc=jkosina@suse.cz \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=peter.hutterer@who-t.net \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).