linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] Set voice_call.watch in correct way
  2010-03-25 16:30 [PATCH] Set voice_call.watch in correct way Forrest Zhao
@ 2010-03-25 10:12 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2010-03-25 10:12 UTC (permalink / raw)
  To: Forrest Zhao; +Cc: linux-bluetooth, forrest.zhao

Hi Forrest,

On Thu, Mar 25, 2010, Forrest Zhao wrote:
> It was set wrongly to device_watch.
> ---
>  audio/telephony-ofono.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/audio/telephony-ofono.c b/audio/telephony-ofono.c
> index c19e6ee..45c3905 100644
> --- a/audio/telephony-ofono.c
> +++ b/audio/telephony-ofono.c
> @@ -850,7 +850,7 @@ static gboolean handle_vcmanager_property_changed(DBusConnection *conn,
>  			vc_new = g_new0(struct voice_call, 1);
>  			vc_new->obj_path = g_strdup(vc_obj_path);
>  			calls = g_slist_append(calls, vc_new);
> -			device_watch = g_dbus_add_signal_watch(connection,
> +			vc_new->watch = g_dbus_add_signal_watch(connection,
>  					NULL, vc_obj_path,
>  					OFONO_VC_INTERFACE,
>  					"PropertyChanged",

Pushed upstream. Thanks.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] Set voice_call.watch in correct way
@ 2010-03-25 16:30 Forrest Zhao
  2010-03-25 10:12 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: Forrest Zhao @ 2010-03-25 16:30 UTC (permalink / raw)
  To: johan.hedberg; +Cc: linux-bluetooth, forrest.zhao, Forrest Zhao

It was set wrongly to device_watch.
---
 audio/telephony-ofono.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/audio/telephony-ofono.c b/audio/telephony-ofono.c
index c19e6ee..45c3905 100644
--- a/audio/telephony-ofono.c
+++ b/audio/telephony-ofono.c
@@ -850,7 +850,7 @@ static gboolean handle_vcmanager_property_changed(DBusConnection *conn,
 			vc_new = g_new0(struct voice_call, 1);
 			vc_new->obj_path = g_strdup(vc_obj_path);
 			calls = g_slist_append(calls, vc_new);
-			device_watch = g_dbus_add_signal_watch(connection,
+			vc_new->watch = g_dbus_add_signal_watch(connection,
 					NULL, vc_obj_path,
 					OFONO_VC_INTERFACE,
 					"PropertyChanged",
-- 
1.6.1.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-25 16:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-25 16:30 [PATCH] Set voice_call.watch in correct way Forrest Zhao
2010-03-25 10:12 ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).