From: Marcel Holtmann <marcel@holtmann.org>
To: "Gustavo F. Padovan" <gustavo@padovan.org>
Cc: Francisco Alecrim <francisco.alecrim@openbossa.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Report local services(UUIDs) through DBus
Date: Thu, 08 Apr 2010 05:57:55 +0200 [thread overview]
Message-ID: <1270699076.6375.20.camel@localhost.localdomain> (raw)
In-Reply-To: <20100407012054.GC23956@vigoh>
Hi Gustavo,
> > +/*
> > + * adapter_services_inc_rem - Insert or remove UUID from adapter
> > + */
> > +static void adapter_service_ins_rem(const bdaddr_t *bdaddr, void *rec,
> > + gboolean insert)
> > +{
> > + struct btd_adapter *adapter;
> > + GSList *adapters;
> > +
> > + adapters = NULL;
> > +
> > + if (bacmp(bdaddr, BDADDR_ANY) != 0) {
> > + /* Only one adapter */
> > + adapter = manager_find_adapter(bdaddr);
> > + if (!adapter)
> > + return;
> > +
> > + adapters = g_slist_append(adapters, adapter);
> > + } else {
> > + /* Emit D-Bus msg to all adapters */
> > + adapters = manager_get_adapters();
> > + }
>
> No need for braces here. :)
because of the comment is is actually preferred to have braces in this
case. This is not for the sake of the compiler. It is purely for humans
to not disturb them with reading the code.
Regards
Marcel
prev parent reply other threads:[~2010-04-08 3:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 22:05 [PATCH 1/2] Report local services(UUIDs) through DBus Francisco Alecrim
2010-04-06 22:05 ` [PATCH 2/2] Correct UUIDs list to EIR Francisco Alecrim
2010-04-08 3:59 ` Marcel Holtmann
2010-04-07 1:20 ` [PATCH 1/2] Report local services(UUIDs) through DBus Gustavo F. Padovan
2010-04-08 3:57 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270699076.6375.20.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=francisco.alecrim@openbossa.org \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).