From: Santiago Carot-Nemesio <scarot@libresoft.es>
To: "Gustavo F. Padovan" <gustavo@padovan.org>
Cc: Santiago Carot-Nemesio <sancane@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] MCAP implementation for BlueZ
Date: Wed, 05 May 2010 09:45:41 +0200 [thread overview]
Message-ID: <1273045541.2105.27.camel@mosquito> (raw)
In-Reply-To: <20100504200657.GC26732@vigoh>
Hi,
El mar, 04-05-2010 a las 17:06 -0300, Gustavo F. Padovan escribió:
> Hi Santiago,
>
> * Santiago Carot-Nemesio <sancane@gmail.com> [2010-05-04 10:43:15 +0200]:
>
> > This patch enables MCAP in BlueZ.
> > Current implementation provides support for standard op. codes. Clock
> > Synchronization protocol is not yet supported.
> > ---
> > Makefile.am | 11 +-
> > acinclude.m4 | 6 +
> > mcap/mcap.c | 2146 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > mcap/mcap.h | 176 +++++
> > mcap/mcap_lib.h | 162 +++++
> > 5 files changed, 2500 insertions(+), 1 deletions(-)
> > create mode 100644 mcap/mcap.c
> > create mode 100644 mcap/mcap.h
> > create mode 100644 mcap/mcap_lib.h
>
> 2500+ lines is too big for review. MCAP is way complicated to
> understand completely. I suggest you to split this patch and send
> smaller ones for each feature of MCAP you implement, then we can review
> each piece and not at once.
You are rigth, I know it, but please, remember that it is a new
specification implemented from scratch, there were not any similar
profile in BlueZ wich i could take as reference point. I have done a lot
of changes in the architecture, interfaces, etc. until I found what IMHO
is a presentable implementation.
Sending patches with a non definitive implementation could have full of
noise the mailing list, I think that its better to have a base
implementation to discuss about.
I'm thinking that it may be interesting put my git in public to
everybody can see all development process, commit-by-commit. I have not
problem in doing that.
>
> Also a MCAP test tool would be interesting to help on the
> review/merge/qualification process. Do you guys have one? Or are you
> planning to do one?
We have some home-made tools and scripts for testing MCAP, if you are
interested i'll put them in plubic git too.
Thanks in advance for your feedback.
Best regards.
next prev parent reply other threads:[~2010-05-05 7:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 8:43 [PATCH] MCAP implementation for BlueZ Santiago Carot-Nemesio
2010-05-04 20:06 ` Gustavo F. Padovan
2010-05-05 7:45 ` Santiago Carot-Nemesio [this message]
2010-05-05 12:15 ` Elvis Pfützenreuter
2010-05-05 13:01 ` Santiago Carot-Nemesio
2010-05-06 8:21 ` [PATCH] MCAP: Added default abort callback Jose Antonio Santos Cadenas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273045541.2105.27.camel@mosquito \
--to=scarot@libresoft.es \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sancane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).