Re: [PATCH v3] hciattach application support for Atheros AR300x Bluetooth Chip

[Marcel Holtmann <marcel@holtmann.org>]

Hi Suraj,

> Implements support for Atheros AR300x Bluetooth chip in hciattach. 
> Adds feature to bring up AR300x Bluetooth chip
> with and without enhanced power management enabled.
> 
> Signed-off-by: Suraj <suraj@Atheros.com>

not SOBs for BlueZ userspace. That is kernel only.

> ---
>  Makefile.tools         |    1 +
>  tools/hciattach.8      |    6 +
>  tools/hciattach.c      |  111 +++++
>  tools/hciattach.h      |    3 +
>  tools/hciattach_ar3k.c | 1223 ++++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 1344 insertions(+), 0 deletions(-)
>  create mode 100755 tools/hciattach_ar3k.c

While hciattach is kinda the bad sheep inside BlueZ, I will enforce the
general coding style for it for all new contributions. So could you
please fix that one first. Otherwise it makes no sense for me to go
through such a big patch if I have to complain about the coding style
breakage for every second line. A general rule is if it fails
check-patch.pl from the kernel, then you are doing something wrong.

Regards

Marcel