Re: [PATCH 1/1] Bluetooth: Synchronize SCO/eSCO connection requests to ACL state

[Marcel Holtmann <marcel@holtmann.org>]

Hi Ron,

> Certain headsets such as the Motorola H350 will reject SCO and eSCO
> connection requests while the ACL is transitioning from sniff mode
> to active mode. Add synchronization so that SCO and eSCO connection
> requests will wait until the ACL has fully transitioned to active mode.

I am not completely happy with this patch. First please split it like
Gustavo asked since otherwise it becomes pretty hard to review. I don't
really bother to look into its technical nature before the split and the
coding style is in place.

Second, please don't make a special case for sniff mode. If we do this
then we also do it for park state and hold mode.

And third, I think this needs to be done a little bit more in the way we
handle attempts for connecting ACL links when the baseband is busy. So
can you send hcidump -X -V traces for the failure of SCO/eSCO setup when
sniff is active. I like to see which error codes are returned. Hacking
this directly into sniff exit handling makes the code pretty hard to
understand in the future.

Regards

Marcel