From: Marcel Holtmann <marcel@holtmann.org>
To: "Perelet, Oleg" <operelet@quicinc.com>
Cc: Ron Shaffer <rshaffer@codeaurora.org>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: RE: [PATCH 1/1] Bluetooth: Synchronize SCO/eSCO connection requests to ACL state
Date: Thu, 27 May 2010 12:34:29 +0200 [thread overview]
Message-ID: <1274956469.4706.2.camel@aeonflux.t-mobile.de> (raw)
In-Reply-To: <BCDE476F204B134B8B235FB275BC3AD805E55D3D3D@NALASEXMB01.na.qualcomm.com>
Hi Oleg,
> Marcel, Here's some prehistory of this patch. 1st Nick did:
>
> http://android.git.kernel.org/?p=kernel/common.git;a=commitdiff;h=201ac2f225a31dffcb05f1db4d609c467c9c694c
>
> which unsniffs connection before doing SCO, otherwise establishing SCO took few seconds on some headsets. Then this patch broke whole bunch of headsets that expected SCO only after unsiff is Acked - that what Ron did.
>
> I had email conversation with Nick about that. IMHO this logic belongs to user land, but because of GPL/Apache conflict libbluetooth can not be lifted in to Android Java/JNI - that's why initial change went to kernel.
>
> If you guys can have some clever way of doing it in bluetoothd - nice. Otherwise this gargantuan kernel patch does fix the problem
I am fine with doing this inside the kernel. It makes perfect sense, but
it needs to be aligned a little bit with the overall way on how we
handle connection setup.
My main question was if it a retry because of failure or if we
preemptively wait until we are in active mode. And that got answered
since the headsets will lock up if we even try.
Regards
Marcel
prev parent reply other threads:[~2010-05-27 10:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 21:11 [PATCH 1/1] Bluetooth: Synchronize SCO/eSCO connection requests to ACL state Ron Shaffer
2010-05-24 21:52 ` Gustavo F. Padovan
2010-05-25 17:00 ` Ron Shaffer
2010-05-25 20:09 ` Gustavo F. Padovan
2010-05-26 8:59 ` Marcel Holtmann
2010-05-26 14:30 ` Ron Shaffer
2010-05-26 15:31 ` Marcel Holtmann
2010-05-26 21:56 ` Ron Shaffer
2010-05-27 3:38 ` Perelet, Oleg
2010-05-27 10:34 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274956469.4706.2.camel@aeonflux.t-mobile.de \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=operelet@quicinc.com \
--cc=rshaffer@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).