From: Marcel Holtmann <marcel@holtmann.org>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
Suraj Sumangala <Suraj.Sumangala@Atheros.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
Jothikumar Mothilal <Jothikumar.Mothilal@Atheros.com>
Subject: Re: [PATCH 2/3] Replace hci_recv_fragment calls
Date: Tue, 01 Jun 2010 14:59:09 -0700 [thread overview]
Message-ID: <1275429550.2182.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20100601205120.GB6037@tux>
Hi Luis,
> > > You want to unify patches 1 and 2. Patches upstream should be atomic so that if you apply it, it should make everything still work. Your first patch removes hci_recv_fragment() and then this one fixes the places that call it, you want to do both in one shot.
> >
> > actually I prefer to leave these two patches out for now. Since the
> > renaming could be done easily later. The important part is actually the
> > other implementation.
>
> Won't that break compilation on the first patch since all existing
> code users no longer have the exported symbol available?
no. The important change here is for the H4 specific stream fragment
handling. The rest is just a renaming. So 3/3 is the important patch and
1/2 and 2/2 are just cosmetic changes.
Regards
Marcel
next prev parent reply other threads:[~2010-06-01 21:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 8:04 [PATCH 1/3] Rename hci_recv_fragment to hci_recv_packet_fragment suraj
2010-06-01 8:08 ` [PATCH 2/3] Replace hci_recv_fragment calls suraj
2010-06-01 8:11 ` [PATCH 3/3] frame reassembly implementation for data from stream suraj
2010-06-01 14:29 ` [PATCH 2/3] Replace hci_recv_fragment calls Luis Rodriguez
2010-06-01 19:59 ` Marcel Holtmann
2010-06-01 20:51 ` Luis R. Rodriguez
2010-06-01 21:59 ` Marcel Holtmann [this message]
2010-06-02 4:11 ` Suraj Sumangala
-- strict thread matches above, loose matches on Subject: below --
2010-06-01 6:54 GLOBAL/suraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275429550.2182.7.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=Jothikumar.Mothilal@Atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=Suraj.Sumangala@Atheros.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).