From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: linux-bluetooth@vger.kernel.org
Cc: gustavo@padovan.org
Subject: [PATCH 2/4] Add debug_string and debug_enabled vars
Date: Fri, 4 Jun 2010 23:23:40 -0300 [thread overview]
Message-ID: <1275704622-5917-2-git-send-email-gustavo@padovan.org> (raw)
In-Reply-To: <1275704622-5917-1-git-send-email-gustavo@padovan.org>
Both will be very useful when we add Debug property to DBus.
---
src/log.c | 20 +++++++++++++++++---
src/log.h | 5 ++++-
2 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/src/log.c b/src/log.c
index 1c0f0b9..d667ed0 100644
--- a/src/log.c
+++ b/src/log.c
@@ -75,6 +75,9 @@ extern struct btd_debug_desc __start___debug[];
extern struct btd_debug_desc __stop___debug[];
static gchar **enabled = NULL;
+static const char *debug_string = NULL;
+
+int debug_enabled = FALSE;
static gboolean is_enabled(struct btd_debug_desc *desc)
{
@@ -103,6 +106,8 @@ static void debug_on(const char *debug)
if (debug != NULL)
enabled = g_strsplit_set(debug, ":, ", 0);
+ debug_enabled = TRUE;
+
for (desc = __start___debug; desc < __stop___debug; desc++) {
if (file != NULL || name != NULL) {
if (g_strcmp0(desc->file, file) == 0) {
@@ -121,6 +126,8 @@ static void debug_off()
{
struct btd_debug_desc *desc;
+ debug_enabled = FALSE;
+
for (desc = __start___debug; desc < __stop___debug; desc++) {
if (is_enabled(desc))
desc->flags &= ~BTD_DEBUG_FLAG_PRINT;
@@ -132,16 +139,23 @@ static void debug_off()
void __btd_toggle_debug()
{
- if (enabled == NULL)
- debug_on("*");
- else
+ if (enabled == NULL) {
+ if (debug_string == NULL)
+ debug_on("*");
+ else
+ debug_on(debug_string);
+ }
+ else {
debug_off();
+ }
}
void __btd_log_init(const char *debug, int detach)
{
int option = LOG_NDELAY | LOG_PID;
+ debug_string = debug;
+
debug_on(debug);
if (!detach)
diff --git a/src/log.h b/src/log.h
index a1530da..f37929c 100644
--- a/src/log.h
+++ b/src/log.h
@@ -24,6 +24,8 @@
#ifndef __LOGGING_H
#define __LOGGING_H
+extern int debug_enabled;
+
void info(const char *format, ...) __attribute__((format(printf, 1, 2)));
void error(const char *format, ...) __attribute__((format(printf, 1, 2)));
void debug(const char *format, ...) __attribute__((format(printf, 1, 2)));
@@ -53,7 +55,8 @@ struct btd_debug_desc {
__attribute__((used, section("__debug"), aligned(8))) = { \
.file = __FILE__, .flags = BTD_DEBUG_FLAG_DEFAULT, \
}; \
- if (__btd_debug_desc.flags & BTD_DEBUG_FLAG_PRINT) \
+ if (__btd_debug_desc.flags & BTD_DEBUG_FLAG_PRINT \
+ && debug_enabled) \
debug("%s:%s() " fmt, \
__FILE__, __FUNCTION__ , ## arg); \
} while (0)
--
1.7.1
next prev parent reply other threads:[~2010-06-05 2:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 2:23 [PATCH 1/4] Fix regression with debug via SIGUSR2 Gustavo F. Padovan
2010-06-05 2:23 ` Gustavo F. Padovan [this message]
2010-06-05 2:23 ` [PATCH 3/4] log: Remove vinfo function Gustavo F. Padovan
2010-06-05 2:23 ` [PATCH 4/4] Remove ifndef barrier from log.h and btio.h Gustavo F. Padovan
-- strict thread matches above, loose matches on Subject: below --
2010-06-04 10:16 [PATCH 1/4] Fix regression with debug via SIGUSR2 Gustavo F. Padovan
2010-06-04 10:16 ` [PATCH 2/4] Add debug_string and debug_enabled vars Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275704622-5917-2-git-send-email-gustavo@padovan.org \
--to=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).