From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: linux-bluetooth@vger.kernel.org
Cc: gustavo@padovan.org, marcel@holtmann.org,
"Gustavo F. Padovan" <padovan@profusion.mobi>
Subject: [PATCH 10/14] Bluetooth: Fix crash when sending frames after connection is closed
Date: Sat, 5 Jun 2010 04:50:14 -0300 [thread overview]
Message-ID: <1275724218-29453-11-git-send-email-gustavo@padovan.org> (raw)
In-Reply-To: <1275724218-29453-10-git-send-email-gustavo@padovan.org>
From: Gustavo F. Padovan <padovan@profusion.mobi>
At the time the channel is closed we can't really know if the timer
was really deleted, since we used del_timer(). We can't call
del_timer_sync() in interrupt context! So sometimes the acktimeout
expires and try to send a acknowledgement, but we don't have any
connection anymore.
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
Reviewed-by: João Paulo Rechi Vita <jprvita@profusion.mobi>
---
net/bluetooth/l2cap.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
index 3db0078..e5b766d 100644
--- a/net/bluetooth/l2cap.c
+++ b/net/bluetooth/l2cap.c
@@ -345,8 +345,12 @@ static inline void l2cap_send_sframe(struct l2cap_pinfo *pi, u16 control)
struct sk_buff *skb;
struct l2cap_hdr *lh;
struct l2cap_conn *conn = pi->conn;
+ struct sock *sk = (struct sock *)pi;
int count, hlen = L2CAP_HDR_SIZE + 2;
+ if (sk->sk_state != BT_CONNECTED)
+ return;
+
if (pi->fcs == L2CAP_FCS_CRC16)
hlen += 2;
--
1.7.1
next prev parent reply other threads:[~2010-06-05 7:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 7:50 Pull request: Fixes for the Enhanced Retransmission Mode Gustavo F. Padovan
2010-06-05 7:50 ` [PATCH 01/14] Bluetooth: Remove max_tx and tx_window modules paramenter from L2CAP Gustavo F. Padovan
2010-06-05 7:50 ` [PATCH 02/14] Bluetooth: Remove L2CAP Extended Features from Kconfig Gustavo F. Padovan
2010-06-05 7:50 ` [PATCH 03/14] Bluetooth: Fix drop of packets with invalid req_seq/tx_seq Gustavo F. Padovan
2010-06-05 7:50 ` [PATCH 04/14] Bluetooth: Check skb_clone return to avoid NULL dereference Gustavo F. Padovan
2010-06-05 7:50 ` [PATCH 05/14] Bluetooth: Fix ERTM vars increment Gustavo F. Padovan
2010-06-05 7:50 ` [PATCH 06/14] Bluetooth: Check packet FCS earlier Gustavo F. Padovan
2010-06-05 7:50 ` [PATCH 07/14] Bluetooth: Only check SAR bits if frame is I-frame Gustavo F. Padovan
2010-06-05 7:50 ` [PATCH 08/14] Bluetooth: Stop ack_timer if ERTM enters in Local Busy or SREJ_SENT Gustavo F. Padovan
2010-06-05 7:50 ` [PATCH 09/14] Bluetooth: Fix ERTM channel shutdown Gustavo F. Padovan
2010-06-05 7:50 ` Gustavo F. Padovan [this message]
2010-06-05 7:50 ` [PATCH 11/14] Bluetooth: Fix handle of received P-bit Gustavo F. Padovan
2010-06-05 7:50 ` [PATCH 12/14] Bluetooth: Fix l2cap_ertm_send() behavior Gustavo F. Padovan
2010-06-05 7:50 ` [PATCH 13/14] Bluetooth: Fix SREJ_QUEUE corruption Gustavo F. Padovan
2010-06-05 7:50 ` [PATCH 14/14] Bluetooth: Fix missing retransmission action with RR(P=1) Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275724218-29453-11-git-send-email-gustavo@padovan.org \
--to=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).