From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: linux-bluetooth@vger.kernel.org
Cc: gustavo@padovan.org
Subject: [PATCH 1/3] sbc: Fix redundant null check on calling free()
Date: Sat, 5 Jun 2010 07:14:28 -0300 [thread overview]
Message-ID: <1275732870-15889-2-git-send-email-gustavo@padovan.org> (raw)
In-Reply-To: <1275732870-15889-1-git-send-email-gustavo@padovan.org>
Issues found by smatch static check: http://smatch.sourceforge.net/
---
sbc/sbc.c | 3 +--
sbc/sbcdec.c | 9 +++------
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/sbc/sbc.c b/sbc/sbc.c
index edd152f..86399dd 100644
--- a/sbc/sbc.c
+++ b/sbc/sbc.c
@@ -1138,8 +1138,7 @@ void sbc_finish(sbc_t *sbc)
if (!sbc)
return;
- if (sbc->priv_alloc_base)
- free(sbc->priv_alloc_base);
+ free(sbc->priv_alloc_base);
memset(sbc, 0, sizeof(sbc_t));
}
diff --git a/sbc/sbcdec.c b/sbc/sbcdec.c
index 77b8aed..7008e88 100644
--- a/sbc/sbcdec.c
+++ b/sbc/sbcdec.c
@@ -259,15 +259,13 @@ int main(int argc, char *argv[])
break;
case 'd':
- if (output)
- free(output);
+ free(output);
output = strdup(optarg);
tofile = 0;
break;
case 'f' :
- if (output)
- free(output);
+ free(output);
output = strdup(optarg);
tofile = 1;
break;
@@ -289,8 +287,7 @@ int main(int argc, char *argv[])
for (i = 0; i < argc; i++)
decode(argv[i], output ? output : "/dev/dsp", tofile);
- if (output)
- free(output);
+ free(output);
return 0;
}
--
1.7.1
next prev parent reply other threads:[~2010-06-05 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 10:14 Fixes issues reported by Smatch static checker Gustavo F. Padovan
2010-06-05 10:14 ` Gustavo F. Padovan [this message]
2010-06-05 10:14 ` [PATCH 2/3] Fix redundant null check on calling free() Gustavo F. Padovan
2010-06-05 10:14 ` [PATCH 3/3] sdptool: Fix 2 possible NULL dereference Gustavo F. Padovan
2010-06-08 6:27 ` Johan Hedberg
2010-06-08 8:02 ` [PATCH 2/3] Fix redundant null check on calling free() Johan Hedberg
2010-06-08 6:21 ` [PATCH 1/3] sbc: " Johan Hedberg
2010-06-08 7:13 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275732870-15889-2-git-send-email-gustavo@padovan.org \
--to=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).