From: Bastien Nocera <hadess@hadess.net>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Get IEEE1284 for a single printer
Date: Tue, 08 Jun 2010 10:21:21 +0100 [thread overview]
Message-ID: <1275988881.2458.12112.camel@localhost.localdomain> (raw)
In-Reply-To: <20100608070935.GA22068@jh-x301>
On Tue, 2010-06-08 at 15:09 +0800, Johan Hedberg wrote:
> Hi Bastien,
>
> On Sun, Jun 06, 2010, Bastien Nocera wrote:
> > Let me know what you think.
>
> Sounds ok'ish to me, but how exactly would udev-configure-printer be
> called? If it's directly executed (as opposed to e.g. using D-Bus) then
> privilege and environment inheritance needs to be considered (i.e. is it
> fine that it gets run with the same privileges and environment as
> bluetoothd itself).
>
> > The patch below could still be useful for debugging (in the worst
> > case).
>
> I have nothing against pushing the patch upstream as long as its coding
> style issues are fixed:
<snip>
> Mixed tabs and spaces.
You do realise that all those are cut'n'paste from another function in
the same source file?
> > + fprintf(stderr, "Invalid Bluetooth address '%s'\n", argv[2]);
>
> Too long line.
Right, I'll fix that.
next prev parent reply other threads:[~2010-06-08 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-06 18:42 [PATCH] Get IEEE1284 for a single printer Bastien Nocera
2010-06-08 7:09 ` Johan Hedberg
2010-06-08 9:21 ` Bastien Nocera [this message]
2010-06-08 9:26 ` Johan Hedberg
2010-09-01 14:35 ` Bastien Nocera
2010-09-01 18:49 ` Johan Hedberg
2010-09-02 10:07 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275988881.2458.12112.camel@localhost.localdomain \
--to=hadess@hadess.net \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).