Re: [PATCH 1/2] log: Add function to get/set debug_string

[Marcel Holtmann <marcel@holtmann.org>]

Hi Gustavo,

>  src/log.c |   53 +++++++++++++++++++++++++++++++++++++++++------------
>  src/log.h |    2 ++
>  2 files changed, 43 insertions(+), 12 deletions(-)
> 
> diff --git a/src/log.c b/src/log.c
> index ed6e428..f53ace3 100644
> --- a/src/log.c
> +++ b/src/log.c
> @@ -71,6 +71,8 @@ extern struct btd_debug_desc __stop___debug[];
>  
>  static gchar **enabled = NULL;
>  
> +static char *debug_string = NULL;
> +

can you please stop messing around with this so much. This looks all so
heavily complicated and convoluted. The log.c is not storing the current
debug command line parameter. It doesn't care about that. So why should
it bother.

Just have a function __btd_enable_debug(const char *debug) and make that
work. You can even use that one from the SIGUSR2 with just "*" as
parameter.

If the D-Bus API wants to present a read-able value of what is the
current string, then that is up to the D-Bus manager object and not the
logging code.

Right now I am actually inclined to just say we don't bother with
changing debug options via D-Bus at all. So I want a simple and clean
patch or we should just not do it at all.

Regards

Marcel