* [PATCH] Bluetooth: Reset the security level after an authentication failure
@ 2010-06-18 8:08 johan.hedberg
2010-06-20 4:08 ` Gustavo F. Padovan
0 siblings, 1 reply; 3+ messages in thread
From: johan.hedberg @ 2010-06-18 8:08 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Johan Hedberg
From: Johan Hedberg <johan.hedberg@nokia.com>
When authentication fails for a connection the assumed security level
should be set back to BT_SECURITY_LOW so that subsequent connect
attempts over the same link don't falsely assume that security is
adequate enough.
Signed-off-by: Johan Hedberg <johan.hedberg@nokia.com>
---
net/bluetooth/hci_event.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 6c57fc7..786b5de 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1049,6 +1049,8 @@ static inline void hci_auth_complete_evt(struct hci_dev *hdev, struct sk_buff *s
if (conn) {
if (!ev->status)
conn->link_mode |= HCI_LM_AUTH;
+ else
+ conn->sec_level = BT_SECURITY_LOW;
clear_bit(HCI_CONN_AUTH_PEND, &conn->pend);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Reset the security level after an authentication failure
2010-06-18 8:08 [PATCH] Bluetooth: Reset the security level after an authentication failure johan.hedberg
@ 2010-06-20 4:08 ` Gustavo F. Padovan
2010-06-29 12:58 ` Andrei Emeltchenko
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo F. Padovan @ 2010-06-20 4:08 UTC (permalink / raw)
To: johan.hedberg; +Cc: linux-bluetooth, Johan Hedberg
Hi Johan,
* johan.hedberg@gmail.com <johan.hedberg@gmail.com> [2010-06-18 11:08:56 +0300]:
> From: Johan Hedberg <johan.hedberg@nokia.com>
>
> When authentication fails for a connection the assumed security level
> should be set back to BT_SECURITY_LOW so that subsequent connect
> attempts over the same link don't falsely assume that security is
> adequate enough.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@nokia.com>
> ---
> net/bluetooth/hci_event.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
It works fine to me.
Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
--
Gustavo F. Padovan
http://padovan.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Reset the security level after an authentication failure
2010-06-20 4:08 ` Gustavo F. Padovan
@ 2010-06-29 12:58 ` Andrei Emeltchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andrei Emeltchenko @ 2010-06-29 12:58 UTC (permalink / raw)
To: Gustavo F. Padovan; +Cc: johan.hedberg, linux-bluetooth, Johan Hedberg
On Sun, Jun 20, 2010 at 7:08 AM, Gustavo F. Padovan <gustavo@padovan.org> wrote:
> Hi Johan,
>
> * johan.hedberg@gmail.com <johan.hedberg@gmail.com> [2010-06-18 11:08:56 +0300]:
>
>> From: Johan Hedberg <johan.hedberg@nokia.com>
>>
>> When authentication fails for a connection the assumed security level
>> should be set back to BT_SECURITY_LOW so that subsequent connect
>> attempts over the same link don't falsely assume that security is
>> adequate enough.
>>
>> Signed-off-by: Johan Hedberg <johan.hedberg@nokia.com>
>> ---
>> net/bluetooth/hci_event.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> It works fine to me.
We have tested this patch.
>
> Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
Reviewed-by: Emeltchenko Andrei <andrei.emeltchenko@nokia.com>
Regards,
Andrei Emeltchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-29 12:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-18 8:08 [PATCH] Bluetooth: Reset the security level after an authentication failure johan.hedberg
2010-06-20 4:08 ` Gustavo F. Padovan
2010-06-29 12:58 ` Andrei Emeltchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).