From: Marcel Holtmann <marcel@holtmann.org>
To: Alan Ott <alan@signal11.us>
Cc: David S Miller <davem@davemloft.net>,
Jiri Kosina <jkosina@suse.cz>,
Michael Poole <mdpoole@troilus.org>,
Bastien Nocera <hadess@hadess.net>,
Eric Dumazet <eric.dumazet@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] Bluetooth: hidp: Add support for hidraw HIDIOCGFEATURE and HIDIOCSFEATURE
Date: Fri, 09 Jul 2010 05:01:37 -0300 [thread overview]
Message-ID: <1278662497.10421.94.camel@localhost.localdomain> (raw)
In-Reply-To: <4C369CDC.9080104@signal11.us>
Hi Alan,
> > I looked at this and I am bit worried that this should not be done in
> > this detail in the HIDP driver. Essentially HIDP is a pure transport
> > driver. It should not handle all these details. Can we make this a bit
> > easier for the transport drivers to support such features?
>
> I put these changes (most notably the addition of hidp_get_raw_report())
> in hidp because that's where the parallel function
> hidp_output_raw_report() was already located. I figured the input should
> go with the output. That said, if there's a better place for both of
> them (input and output) to go, let me know where you think it should be,
> and I'll get them moved into the proper spot.
>
> I'm not sure what you mean about HIDP being a pure transport driver.
what is usb-hid.ko doing here? I would expect a bunch of code
duplication with minor difference between USB and Bluetooth.
Regards
Marcel
next prev parent reply other threads:[~2010-07-09 8:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 22:20 [PATCH 1/1] Bluetooth: hidp: Add support for hidraw HIDIOCGFEATURE and HIDIOCSFEATURE Alan Ott
2010-06-19 17:49 ` Jiri Kosina
2010-06-28 11:14 ` Antonio Ospite
2010-06-29 7:12 ` David Miller
2010-06-29 8:50 ` Jiri Kosina
2010-06-29 9:07 ` Johan Hedberg
2010-06-29 12:40 ` Andrei Emeltchenko
2010-07-08 21:08 ` Marcel Holtmann
2010-07-08 21:11 ` Marcel Holtmann
2010-07-09 3:51 ` Alan Ott
2010-07-09 8:01 ` Marcel Holtmann [this message]
2010-07-09 13:02 ` Alan Ott
2010-07-09 13:06 ` Marcel Holtmann
2010-07-09 14:06 ` Alan Ott
2010-07-09 17:33 ` Marcel Holtmann
2010-07-09 18:24 ` Alan Ott
2010-07-22 14:14 ` Jiri Kosina
2010-07-22 15:21 ` Marcel Holtmann
2010-07-22 16:58 ` Alan Ott
2010-08-10 11:46 ` Jiri Kosina
2010-08-10 12:12 ` Marcel Holtmann
2010-08-16 20:20 ` [PATCH v4 0/2] Get and Set Feature Reports on HIDRAW (USB and Bluetooth) Alan Ott
2010-08-23 13:00 ` Jiri Kosina
2010-09-02 15:25 ` Jiri Kosina
2010-09-22 12:09 ` Jiri Kosina
2010-11-01 19:23 ` Jiri Kosina
2010-11-08 11:17 ` Antonio Ospite
2010-09-23 16:25 ` Ville Tervo
2010-09-23 17:07 ` Ping Cheng
2010-09-23 20:16 ` Przemo Firszt
2010-09-23 23:40 ` Alan Ott
2010-08-16 20:20 ` [PATCH v4 1/2] HID: Add Support for Setting and Getting Feature Reports from hidraw Alan Ott
2010-09-28 13:30 ` Antonio Ospite
2010-10-01 13:30 ` Jiri Kosina
2010-08-16 20:20 ` [PATCH v4 2/2] Bluetooth: hidp: Add support for hidraw HIDIOCGFEATURE and HIDIOCSFEATURE Alan Ott
2010-09-23 11:51 ` Ville Tervo
2010-09-23 14:16 ` Alan Ott
2010-09-24 10:47 ` Antonio Ospite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278662497.10421.94.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=alan@signal11.us \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hadess@hadess.net \
--cc=jkosina@suse.cz \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdpoole@troilus.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).