From: Marcel Holtmann <marcel@holtmann.org>
To: "Perelet, Oleg" <operelet@quicinc.com>
Cc: Ron Shaffer <rshaffer@codeaurora.org>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"Wilson, Matt" <mtwilson@quicinc.com>
Subject: RE: [PATCH 3/3] Bluetooth: Synchronize SCO/eSCO connection requests to ACL state
Date: Wed, 14 Jul 2010 16:30:03 -0300 [thread overview]
Message-ID: <1279135803.6282.58.camel@localhost.localdomain> (raw)
In-Reply-To: <BCDE476F204B134B8B235FB275BC3AD810407AA0CD@NALASEXMB01.na.qualcomm.com>
Hi Oleg,
> >I find your patch actually highly complicated. So I tried to capture
> >your intend the in the attached patch (only compiled test) and it would
> >be good if you can try that.
>
> Marcel, your fix is mode delicate compared to original and has same functionality.
>
> There's small problem with both yours & Rons - there's no error handling for case when other device will never ACK's unsniff - you pretty much DOS session if there's no reply. No real HS will do that but it may present security flaw. I do not know how severe is that
>
> I attached original conversation when we 1st time seen the problem.
is there really a problem? The LMP will send an error via HCI. So we do
get the mode changed event, but just with an error. And since we are not
checking the error at all, we just go ahead with the SCO setup attempt
in that case.
Regards
Marcel
next prev parent reply other threads:[~2010-07-14 19:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 15:53 [PATCH v3 0/3] Don't send SCO/eSCO request during a mode change from sniff to active Ron Shaffer
2010-05-28 15:53 ` [PATCH 1/3] Bluetooth: Remove extraneous white space Ron Shaffer
2010-07-08 21:49 ` Marcel Holtmann
2010-05-28 15:53 ` [PATCH 2/3] Bluetooth: Reassigned copyright to Code Aurora Forum Ron Shaffer
2010-07-08 21:49 ` Marcel Holtmann
2010-05-28 15:53 ` [PATCH 3/3] Bluetooth: Synchronize SCO/eSCO connection requests to ACL state Ron Shaffer
2010-07-08 21:49 ` Marcel Holtmann
2010-07-12 21:06 ` Ron Shaffer
2010-07-12 22:07 ` Marcel Holtmann
2010-07-14 19:20 ` Perelet, Oleg
2010-07-14 19:30 ` Marcel Holtmann [this message]
2010-07-14 20:55 ` Matthew Wilson
2010-07-14 20:59 ` Matt Wilson
2010-07-15 3:07 ` Perelet, Oleg
2010-07-15 6:16 ` Marcel Holtmann
2010-07-15 17:23 ` Perelet, Oleg
2010-07-15 6:13 ` Marcel Holtmann
2010-07-19 22:07 ` Matt Wilson
2010-07-15 21:38 ` Ron Shaffer
2010-07-16 16:32 ` Marcel Holtmann
2010-06-03 20:00 ` [PATCH v3 0/3] Don't send SCO/eSCO request during a mode change from sniff to active Ron Shaffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279135803.6282.58.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mtwilson@quicinc.com \
--cc=operelet@quicinc.com \
--cc=rshaffer@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).