linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>
To: "Gustavo F. Padovan" <gustavo@padovan.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	linux-bluetooth@vger.kernel.org
Subject: Re: bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa
Date: Fri, 16 Jul 2010 20:46:44 +0200	[thread overview]
Message-ID: <1279306004.29479.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20100716180817.GA10326@vigoh>


[-- Attachment #1.1: Type: text/plain, Size: 1823 bytes --]

El vie, 16-07-2010 a las 15:08 -0300, Gustavo F. Padovan escribió:
> Hi Pacho,
> 
> * Pacho Ramos <pacho@condmat1.ciencias.uniovi.es> [2010-07-16 19:21:45 +0200]:
> 
> > El vie, 16-07-2010 a las 14:01 -0300, Johan Hedberg escribió:
> > > 
> > > On Fri, Jul 16, 2010, Pacho Ramos wrote:
> > > > Can this be finally committed please? Thanks a lot :-)
> > > 
> > > It's strange the the patch has gone unnoticed ever since March. Anyway,
> > > could you please provide a git format-patch version of it since that's
> > > the convention for all patch submisions. That way I don't need to play
> > > manual tricks to get the git author name and email correct for the
> > > commit.
> > > 
> > > Johan
> > > 
> > 
> > Sadly I have always failed to create patches in a git format-patch
> > version :'(
> > 
> > This is what I have tried:
> > $ git clone git://git.kernel.org/pub/scm/bluetooth/bluez.git
> > Initialized empty Git repository in /home/pacho/bluez/.git/
> > remote: Counting objects: 35451, done.
> > remote: Compressing objects: 100% (8577/8577), done.
> > remote: Total 35451 (delta 27190), reused 34976 (delta 26858)
> > Receiving objects: 100% (35451/35451), 6.16 MiB | 1.39 MiB/s, done.
> > Resolving deltas: 100% (27190/27190), done.
> > $ cd bluez/
> > $ git checkout -b fix_alsa_path
> > Switched to a new branch 'fix_alsa_path'
> > $ patch -p0
> > </usr/portage/net-wireless/bluez/files/bluez-alsa_location.patch 
> > patching file Makefile.am
> > Hunk #1 succeeded at 248 (offset 7 lines).
> > $ git format-patch master --stdout
> > $ (nothing is shown)
> 
> If your patch is on HEAD then just do:
> 
> git format-patch -1
> 
> and then use 'git send-email' to send it to the mailing list.
> 

Seems I forgot to commit ;-), I attach the patch

Thanks :-)


[-- Attachment #1.2: 0001-Install-alsa-stuff-in-correct-place.patch --]
[-- Type: text/x-patch, Size: 731 bytes --]

From 4421d83d1d5cd0875ec12457f621a31fdc8862a1 Mon Sep 17 00:00:00 2001
From: Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>
Date: Fri, 16 Jul 2010 20:38:58 +0200
Subject: [PATCH] Install alsa stuff in correct place

---
 Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index f4bf87d..65d4312 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -248,7 +248,7 @@ audio_libasound_module_ctl_bluetooth_la_LIBADD = lib/libbluetooth.la @ALSA_LIBS@
 audio_libasound_module_ctl_bluetooth_la_CFLAGS = @ALSA_CFLAGS@
 
 if CONFIGFILES
-alsaconfdir = $(sysconfdir)/alsa
+alsaconfdir = $(datadir)/alsa
 
 alsaconf_DATA = audio/bluetooth.conf
 endif
-- 
1.7.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2010-07-16 18:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04  8:37 bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa Pacho Ramos
2010-03-05  1:42 ` Marcel Holtmann
2010-03-05  9:11   ` Pacho Ramos
2010-03-05  9:24     ` Pacho Ramos
2010-04-10 11:28       ` Pacho Ramos
2010-07-16 10:40         ` Pacho Ramos
2010-07-16 17:01           ` Johan Hedberg
2010-07-16 17:21             ` Pacho Ramos
2010-07-16 18:08               ` Gustavo F. Padovan
2010-07-16 18:46                 ` Pacho Ramos [this message]
2010-07-16 23:44                   ` Johan Hedberg
2010-07-17 14:09                     ` Pacho Ramos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279306004.29479.3.camel@localhost.localdomain \
    --to=pacho@condmat1.ciencias.uniovi.es \
    --cc=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).