Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Suraj Sumangala <suraj@atheros.com>
Cc: linux-bluetooth@vger.kernel.org, Jothikumar.Mothilal@Atheros.com
Subject: Re: [RFC] Bluetooth: Provide access to reassembled Rx packets
Date: Sun, 25 Jul 2010 23:13:08 -0700	[thread overview]
Message-ID: <1280124788.2621.37.camel@localhost.localdomain> (raw)
In-Reply-To: <1280124157-16693-1-git-send-email-suraj@atheros.com>

Hi Suraj,

> Provide the HCI transport driver access to reassembled Rx packets before
> sending to Host.
> 
> Signed-off-by: Suraj Sumangala <suraj@atheros.com>
> ---
>  include/net/bluetooth/hci_core.h |    1 +
>  net/bluetooth/hci_core.c         |    4 ++++
>  2 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index 350b3e6..769530b 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -156,6 +156,7 @@ struct hci_dev {
>  	int (*close)(struct hci_dev *hdev);
>  	int (*flush)(struct hci_dev *hdev);
>  	int (*send)(struct sk_buff *skb);
> +	int (*recv)(struct hci_dev *hdev, struct sk_buff *skb);

besides the fact that skb->dev == hdev, why would be doing something
like this? This is highly inefficient.

Regards

Marcel



  reply	other threads:[~2010-07-26  6:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-26  6:02 [RFC] Bluetooth: Provide access to reassembled Rx packets Suraj Sumangala
2010-07-26  6:13 ` Marcel Holtmann [this message]
2010-07-26  6:27   ` Suraj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280124788.2621.37.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=Jothikumar.Mothilal@Atheros.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=suraj@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox