From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: "Counihan, Tom" <tom.counihan@intel.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] De-register pbap drivers on init failure scenarios
Date: Tue, 27 Jul 2010 08:41:27 -0700 [thread overview]
Message-ID: <1280245287.2621.78.camel@localhost.localdomain> (raw)
In-Reply-To: <20100727123129.GA6483@jh-x301>
Hi Johan,
> > Unwind the driver registration/phonebook initialization stack on pbap plugin init failure scenarios.
> >
> >
> > ---
> > plugins/pbap.c | 25 ++++++++++++++++++++-----
> > 1 files changed, 20 insertions(+), 5 deletions(-)
>
> Thanks for the patch! It's now upstream. In the future please pay
> attention to your commit message line length. It shouldn't exceed 74
> characters (or so) in order to be nicely viewable on a 80-character wide
> terminal using git log. I fixed it this time for you manually.
please pay attention to Outlook/Exchange users where the the firstname,
lastname thing is reversed :(
Tom, Ensure that patches have a proper From: line first with the correct
name in the correct order.
Regards
Marcel
prev parent reply other threads:[~2010-07-27 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 11:28 [PATCH] De-register pbap drivers on init failure scenarios Counihan, Tom
2010-07-27 12:31 ` Johan Hedberg
2010-07-27 15:41 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280245287.2621.78.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=tom.counihan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).