linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Ron Shaffer <rshaffer@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, johan.hedberg@gmail.com
Subject: Re: [PATCH v3] Bluetooth: Defer SCO setup if mode change is pending
Date: Tue, 27 Jul 2010 12:40:29 -0700	[thread overview]
Message-ID: <1280259629.2621.93.camel@localhost.localdomain> (raw)
In-Reply-To: <1280153160-7166-1-git-send-email-rshaffer@codeaurora.org>

Hi Ron,

> Certain headsets such as the Motorola H350 will reject SCO and eSCO
> connection requests while the ACL is transitioning from sniff mode
> to active mode. Add synchronization so that SCO and eSCO connection
> requests will wait until the ACL has fully transitioned to active mode.
> 
> < HCI Command: Exit Sniff Mode (0x02|0x0004) plen 2
>     handle 12
> > HCI Event: Command Status (0x0f) plen 4
>     Exit Sniff Mode (0x02|0x0004) status 0x00 ncmd 1
> < HCI Command:  Setup Synchronous Connection (0x01|0x0028) plen 17
>     handle 12 voice setting 0x0040
> > HCI Event: Command Status (0x0f) plen 4
>     Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 1
> > HCI Event: Number of Completed Packets (0x13) plen 5
>     handle 12 packets 1
> > HCI Event: Mode Change (0x14) plen 6
>     status 0x00 handle 12 mode 0x00 interval 0
>     Mode: Active
> > HCI Event: Synchronous Connect Complete (0x2c) plen 17
>     status 0x10 handle 14 bdaddr 00:1A:0E:50:28:A4 type SCO
>     Error: Connection Accept Timeout Exceeded
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> Signed-off-by: Ron Shaffer <rshaffer@codeaurora.org>
> ---
>  include/net/bluetooth/hci_core.h |    2 ++
>  net/bluetooth/hci_conn.c         |   32 ++++++++++++++++++++++++++++----
>  net/bluetooth/hci_event.c        |   33 +++++++++++++++++----------------
>  3 files changed, 47 insertions(+), 20 deletions(-)

I did a small cleanup, but patch has been applied now.

Regards

Marcel



      reply	other threads:[~2010-07-27 19:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-19 18:06 [PATCH] Bluetooth: Defer SCO setup if mode change is pending Marcel Holtmann
2010-07-20  4:44 ` Ron Shaffer
2010-07-20 16:56   ` Marcel Holtmann
2010-07-22 19:45     ` [PATCH v2] " Ron Shaffer
2010-07-23  2:48       ` Marcel Holtmann
2010-07-23 15:39         ` Ron Shaffer
2010-07-25 18:41           ` Marcel Holtmann
2010-07-26 14:06             ` [PATCH v3] " Ron Shaffer
2010-07-27 19:40               ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280259629.2621.93.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=rshaffer@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).