From: Marcel Holtmann <marcel@holtmann.org>
To: "Gustavo F. Padovan" <gustavo@padovan.org>
Cc: Dan Carpenter <error27@gmail.com>,
Suraj Sumangala <suraj@atheros.com>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] bluetooth/hci_ath: kfree() => kfree_skb()
Date: Tue, 27 Jul 2010 15:28:58 -0700 [thread overview]
Message-ID: <1280269738.2621.94.camel@localhost.localdomain> (raw)
In-Reply-To: <20100723181053.GN2620@vigoh>
Hi Dan,
> > sk_buffs have to be freed with kfree_skb() instead of kfree().
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> >
> > diff --git a/drivers/bluetooth/hci_ath.c b/drivers/bluetooth/hci_ath.c
> > index 5ab258b..74a8f61 100755
> > --- a/drivers/bluetooth/hci_ath.c
> > +++ b/drivers/bluetooth/hci_ath.c
> > @@ -163,7 +163,7 @@ static int ath_enqueue(struct hci_uart *hu, struct sk_buff *skb)
> > struct ath_struct *ath = hu->priv;
> >
> > if (bt_cb(skb)->pkt_type == HCI_SCODATA_PKT) {
> > - kfree(skb);
> > + kfree_skb(skb);
> > return 0;
> > }
>
> Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
patch has been applied. Thanks.
Regards
Marcel
prev parent reply other threads:[~2010-07-27 22:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 10:11 [patch -next] bluetooth/hci_ath: kfree() => kfree_skb() Dan Carpenter
2010-07-23 18:10 ` Gustavo F. Padovan
2010-07-27 22:28 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280269738.2621.94.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=error27@gmail.com \
--cc=gustavo@padovan.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=suraj@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).