linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch to improve cupsdir detection
@ 2010-09-07 10:18 Pacho Ramos
  2010-09-07 12:48 ` Bastien Nocera
  0 siblings, 1 reply; 2+ messages in thread
From: Pacho Ramos @ 2010-09-07 10:18 UTC (permalink / raw)
  To: BlueZ development

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Hello

Since really a lot of time we are shipping in Gentoo attached patch to
adapt cupsdir to our cups installations (that uses /usr/libexec/cups
instead of /usr/lib) :
diff --git a/Makefile.tools b/Makefile.tools
index d9a2425..a382e05 100644
--- a/Makefile.tools
+++ b/Makefile.tools
@@ -122,7 +122,7 @@ EXTRA_DIST += tools/dfubabel.1 tools/avctrl.8
 
 
 if CUPS
-cupsdir = $(libdir)/cups/backend
+cupsdir = `cups-config --serverbin`/backend
 
 cups_PROGRAMS = cups/bluetooth

I send this to inform you about it and, if possible, get it
upstreamed :-)

Thanks a lot


[-- Attachment #2: cups-location.patch --]
[-- Type: text/x-patch, Size: 311 bytes --]

diff --git a/Makefile.tools b/Makefile.tools
index d9a2425..a382e05 100644
--- a/Makefile.tools
+++ b/Makefile.tools
@@ -122,7 +122,7 @@ EXTRA_DIST += tools/dfubabel.1 tools/avctrl.8
 
 
 if CUPS
-cupsdir = $(libdir)/cups/backend
+cupsdir = `cups-config --serverbin`/backend
 
 cups_PROGRAMS = cups/bluetooth
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Patch to improve cupsdir detection
  2010-09-07 10:18 Patch to improve cupsdir detection Pacho Ramos
@ 2010-09-07 12:48 ` Bastien Nocera
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien Nocera @ 2010-09-07 12:48 UTC (permalink / raw)
  To: Pacho Ramos; +Cc: BlueZ development

On Tue, 2010-09-07 at 12:18 +0200, Pacho Ramos wrote:
> Hello
> 
> Since really a lot of time we are shipping in Gentoo attached patch to
> adapt cupsdir to our cups installations (that uses /usr/libexec/cups
> instead of /usr/lib) :
> diff --git a/Makefile.tools b/Makefile.tools
> index d9a2425..a382e05 100644
> --- a/Makefile.tools
> +++ b/Makefile.tools
> @@ -122,7 +122,7 @@ EXTRA_DIST += tools/dfubabel.1 tools/avctrl.8
>  
> 
>  if CUPS
> -cupsdir = $(libdir)/cups/backend
> +cupsdir = `cups-config --serverbin`/backend
>  
>  cups_PROGRAMS = cups/bluetooth
> 
> I send this to inform you about it and, if possible, get it
> upstreamed :-)

Given that the cups backend doesn't actually require the cups headers or
development packages, you'd need to check for cups-config existing, and
then use a nice default if not present.

This should be done in acinclude.m4, with a new macro, which will get
added to the generated configure.

Cheers


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-07 12:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-07 10:18 Patch to improve cupsdir detection Pacho Ramos
2010-09-07 12:48 ` Bastien Nocera

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).