* [PATCH] Fix Headset Audio gateway SDP record.
@ 2010-09-21 23:50 y
0 siblings, 0 replies; 4+ messages in thread
From: y @ 2010-09-21 23:50 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Jaikumar Ganesh
From: Jaikumar Ganesh <jaikumar@google.com>
Headset Audio Gateway does not have the Supported Features
in the SDP records according to the HSP specification.
---
tools/sdptool.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/tools/sdptool.c b/tools/sdptool.c
index d06b159..140a46a 100644
--- a/tools/sdptool.c
+++ b/tools/sdptool.c
@@ -1477,8 +1477,7 @@ static int add_headset_ag(sdp_session_t *session, svc_info_t *si)
sdp_list_t *aproto, *proto[2];
sdp_record_t record;
uint8_t u8 = si->channel ? si->channel : 7;
- uint16_t u16 = 0x17;
- sdp_data_t *channel, *features;
+ sdp_data_t *channel;
uint8_t netid = si->network ? si->network : 0x01; // ???? profile document
sdp_data_t *network = sdp_data_alloc(SDP_UINT8, &netid);
int ret = 0;
@@ -1511,9 +1510,6 @@ static int add_headset_ag(sdp_session_t *session, svc_info_t *si)
proto[1] = sdp_list_append(proto[1], channel);
apseq = sdp_list_append(apseq, proto[1]);
- features = sdp_data_alloc(SDP_UINT16, &u16);
- sdp_attr_add(&record, SDP_ATTR_SUPPORTED_FEATURES, features);
-
aproto = sdp_list_append(0, apseq);
sdp_set_access_protos(&record, aproto);
--
1.6.5.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix Headset Audio gateway SDP record.
[not found] <4447611680690660620@unknownmsgid>
@ 2010-09-22 0:05 ` jaikumar Ganesh
0 siblings, 0 replies; 4+ messages in thread
From: jaikumar Ganesh @ 2010-09-22 0:05 UTC (permalink / raw)
To: y; +Cc: linux-bluetooth, Jaikumar Ganesh
Please ignore. Sending again with a valid "to address".
On Tue, Sep 21, 2010 at 4:50 PM, <y@google.com> wrote:
> From: Jaikumar Ganesh <jaikumar@google.com>
>
> Headset Audio Gateway does not have the Supported Features
> in the SDP records according to the HSP specification.
> ---
> tools/sdptool.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/tools/sdptool.c b/tools/sdptool.c
> index d06b159..140a46a 100644
> --- a/tools/sdptool.c
> +++ b/tools/sdptool.c
> @@ -1477,8 +1477,7 @@ static int add_headset_ag(sdp_session_t *session, svc_info_t *si)
> sdp_list_t *aproto, *proto[2];
> sdp_record_t record;
> uint8_t u8 = si->channel ? si->channel : 7;
> - uint16_t u16 = 0x17;
> - sdp_data_t *channel, *features;
> + sdp_data_t *channel;
> uint8_t netid = si->network ? si->network : 0x01; // ???? profile document
> sdp_data_t *network = sdp_data_alloc(SDP_UINT8, &netid);
> int ret = 0;
> @@ -1511,9 +1510,6 @@ static int add_headset_ag(sdp_session_t *session, svc_info_t *si)
> proto[1] = sdp_list_append(proto[1], channel);
> apseq = sdp_list_append(apseq, proto[1]);
>
> - features = sdp_data_alloc(SDP_UINT16, &u16);
> - sdp_attr_add(&record, SDP_ATTR_SUPPORTED_FEATURES, features);
> -
> aproto = sdp_list_append(0, apseq);
> sdp_set_access_protos(&record, aproto);
>
> --
> 1.6.5.7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Fix Headset Audio gateway SDP record.
@ 2010-09-22 0:05 Jaikumar Ganesh
2010-09-22 7:22 ` Johan Hedberg
0 siblings, 1 reply; 4+ messages in thread
From: Jaikumar Ganesh @ 2010-09-22 0:05 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Jaikumar Ganesh
Headset Audio Gateway does not have the Supported Features
in the SDP records according to the HSP specification.
---
tools/sdptool.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/tools/sdptool.c b/tools/sdptool.c
index d06b159..140a46a 100644
--- a/tools/sdptool.c
+++ b/tools/sdptool.c
@@ -1477,8 +1477,7 @@ static int add_headset_ag(sdp_session_t *session, svc_info_t *si)
sdp_list_t *aproto, *proto[2];
sdp_record_t record;
uint8_t u8 = si->channel ? si->channel : 7;
- uint16_t u16 = 0x17;
- sdp_data_t *channel, *features;
+ sdp_data_t *channel;
uint8_t netid = si->network ? si->network : 0x01; // ???? profile document
sdp_data_t *network = sdp_data_alloc(SDP_UINT8, &netid);
int ret = 0;
@@ -1511,9 +1510,6 @@ static int add_headset_ag(sdp_session_t *session, svc_info_t *si)
proto[1] = sdp_list_append(proto[1], channel);
apseq = sdp_list_append(apseq, proto[1]);
- features = sdp_data_alloc(SDP_UINT16, &u16);
- sdp_attr_add(&record, SDP_ATTR_SUPPORTED_FEATURES, features);
-
aproto = sdp_list_append(0, apseq);
sdp_set_access_protos(&record, aproto);
--
1.6.5.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix Headset Audio gateway SDP record.
2010-09-22 0:05 [PATCH] Fix Headset Audio gateway SDP record Jaikumar Ganesh
@ 2010-09-22 7:22 ` Johan Hedberg
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hedberg @ 2010-09-22 7:22 UTC (permalink / raw)
To: Jaikumar Ganesh; +Cc: linux-bluetooth
Hi Jaikumar,
On Tue, Sep 21, 2010, Jaikumar Ganesh wrote:
> Headset Audio Gateway does not have the Supported Features
> in the SDP records according to the HSP specification.
> ---
> tools/sdptool.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
Thanks. The patch has been pushed upstream.
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-22 7:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-22 0:05 [PATCH] Fix Headset Audio gateway SDP record Jaikumar Ganesh
2010-09-22 7:22 ` Johan Hedberg
[not found] <4447611680690660620@unknownmsgid>
2010-09-22 0:05 ` jaikumar Ganesh
-- strict thread matches above, loose matches on Subject: below --
2010-09-21 23:50 y
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).