linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: clean up rfcomm code
Date: Tue, 05 Oct 2010 09:53:56 +0200	[thread overview]
Message-ID: <1286265236.17473.26.camel@aeonflux> (raw)
In-Reply-To: <1285923911-12902-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

Hi Andrei,

> Remove dead code and unused rfcomm thread events
> 
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
> ---
>  include/net/bluetooth/rfcomm.h |    5 -----
>  net/bluetooth/rfcomm/core.c    |   29 ++++++++++++++---------------
>  2 files changed, 14 insertions(+), 20 deletions(-)
> 
> diff --git a/include/net/bluetooth/rfcomm.h b/include/net/bluetooth/rfcomm.h
> index a140847..71047bc 100644
> --- a/include/net/bluetooth/rfcomm.h
> +++ b/include/net/bluetooth/rfcomm.h
> @@ -213,11 +213,6 @@ struct rfcomm_dlc {
>  #define RFCOMM_DEFER_SETUP  8
>  
>  /* Scheduling flags and events */
> -#define RFCOMM_SCHED_STATE  0
> -#define RFCOMM_SCHED_RX     1
> -#define RFCOMM_SCHED_TX     2
> -#define RFCOMM_SCHED_TIMEO  3
> -#define RFCOMM_SCHED_AUTH   4
>  #define RFCOMM_SCHED_WAKEUP 31

we had some big ambition to use these, but never did in the end or
realized that they are not needed. So I am fine with removing these.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



  reply	other threads:[~2010-10-05  7:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-01  9:05 [PATCH] Bluetooth: clean up rfcomm code Emeltchenko Andrei
2010-10-05  7:53 ` Marcel Holtmann [this message]
2010-10-05 19:42   ` Gustavo F. Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286265236.17473.26.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=Andrei.Emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).