From: Marcel Holtmann <marcel@holtmann.org>
To: Haijun Liu <haijun.liu@atheros.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Fix system crash caused by del_timer()
Date: Tue, 26 Oct 2010 16:24:53 +0200 [thread overview]
Message-ID: <1288103093.3613.21.camel@aeonflux> (raw)
In-Reply-To: <1287644956-12602-1-git-send-email-haijun.liu@atheros.com>
Hi Haijun,
> At UPF37, during test session of bt3.0 with Marvel, found that in
> l2cap_chan_del() using del_timer() caused l2cap_monitor_timeout()
> be called after the sock was freed, so it raised a system crash.
> So I just replaced del_timer() with del_timer_sync() to solve it.
>
> Signed-off-by: Haijun Liu <haijun.liu@atheros.com>
looks good to me and if Gustavo agrees, then
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2010-10-26 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 7:09 [PATCH 1/2] Bluetooth: Fix system crash caused by del_timer() Haijun Liu
2010-10-21 7:09 ` [PATCH 2/2] Bluetooth: Fix system crash bug of no send queue protect Haijun Liu
2010-10-26 14:36 ` haijun liu
2010-10-26 14:24 ` Marcel Holtmann [this message]
2010-10-26 14:33 ` [PATCH 1/2] Bluetooth: Fix system crash caused by del_timer() haijun liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288103093.3613.21.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=haijun.liu@atheros.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox