linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: linux-bluetooth@vger.kernel.org
Subject: [bluetooth-next 12/16] Bluetooth: move l2cap_sock_shutdown() to l2cap_sock.c
Date: Fri,  4 Feb 2011 04:01:54 -0200	[thread overview]
Message-ID: <1296799318-5517-13-git-send-email-padovan@profusion.mobi> (raw)
In-Reply-To: <1296799318-5517-12-git-send-email-padovan@profusion.mobi>

Declare __l2cap_wait_ack() and  l2cap_sock_clear_timer() in l2cap.h

Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
---
 include/net/bluetooth/l2cap.h |    3 ++-
 net/bluetooth/l2cap_core.c    |   35 ++---------------------------------
 net/bluetooth/l2cap_sock.c    |   31 +++++++++++++++++++++++++++++++
 3 files changed, 35 insertions(+), 34 deletions(-)

diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
index 336b2af7..c9df0ef 100644
--- a/include/net/bluetooth/l2cap.h
+++ b/include/net/bluetooth/l2cap.h
@@ -434,8 +434,10 @@ void l2cap_cleanup_sockets(void);
 u8 l2cap_get_ident(struct l2cap_conn *conn);
 void l2cap_send_cmd(struct l2cap_conn *conn, u8 ident, u8 code, u16 len, void *data);
 int l2cap_build_conf_req(struct sock *sk, void *data);
+int __l2cap_wait_ack(struct sock *sk);
 
 void l2cap_sock_set_timer(struct sock *sk, long timeout);
+void l2cap_sock_clear_timer(struct sock *sk);
 void __l2cap_sock_close(struct sock *sk, int reason);
 void l2cap_sock_kill(struct sock *sk);
 void l2cap_sock_init(struct sock *sk, struct sock *parent);
@@ -444,7 +446,6 @@ struct sock *l2cap_sock_alloc(struct net *net, struct socket *sock,
 int l2cap_do_connect(struct sock *sk);
 
 int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghdr *msg, size_t len);
-int l2cap_sock_shutdown(struct socket *sock, int how);
 
 
 void l2cap_load(void);
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 8184d54..0368a2e 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -84,7 +84,7 @@ void l2cap_sock_set_timer(struct sock *sk, long timeout)
 	sk_reset_timer(sk, &sk->sk_timer, jiffies + timeout);
 }
 
-static void l2cap_sock_clear_timer(struct sock *sk)
+void l2cap_sock_clear_timer(struct sock *sk)
 {
 	BT_DBG("sock %p state %d", sk, sk->sk_state);
 	sk_stop_timer(sk, &sk->sk_timer);
@@ -906,7 +906,7 @@ done:
 	return err;
 }
 
-static int __l2cap_wait_ack(struct sock *sk)
+int __l2cap_wait_ack(struct sock *sk)
 {
 	DECLARE_WAITQUEUE(wait, current);
 	int err = 0;
@@ -1467,37 +1467,6 @@ done:
 	return err;
 }
 
-int l2cap_sock_shutdown(struct socket *sock, int how)
-{
-	struct sock *sk = sock->sk;
-	int err = 0;
-
-	BT_DBG("sock %p, sk %p", sock, sk);
-
-	if (!sk)
-		return 0;
-
-	lock_sock(sk);
-	if (!sk->sk_shutdown) {
-		if (l2cap_pi(sk)->mode == L2CAP_MODE_ERTM)
-			err = __l2cap_wait_ack(sk);
-
-		sk->sk_shutdown = SHUTDOWN_MASK;
-		l2cap_sock_clear_timer(sk);
-		__l2cap_sock_close(sk, 0);
-
-		if (sock_flag(sk, SOCK_LINGER) && sk->sk_lingertime)
-			err = bt_sock_wait_state(sk, BT_CLOSED,
-							sk->sk_lingertime);
-	}
-
-	if (!err && sk->sk_err)
-		err = -sk->sk_err;
-
-	release_sock(sk);
-	return err;
-}
-
 static void l2cap_chan_ready(struct sock *sk)
 {
 	struct sock *parent = bt_sk(sk)->parent;
diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
index fa2bc5d..93af233 100644
--- a/net/bluetooth/l2cap_sock.c
+++ b/net/bluetooth/l2cap_sock.c
@@ -723,6 +723,37 @@ static int l2cap_sock_recvmsg(struct kiocb *iocb, struct socket *sock, struct ms
 	return bt_sock_recvmsg(iocb, sock, msg, len, flags);
 }
 
+static int l2cap_sock_shutdown(struct socket *sock, int how)
+{
+	struct sock *sk = sock->sk;
+	int err = 0;
+
+	BT_DBG("sock %p, sk %p", sock, sk);
+
+	if (!sk)
+		return 0;
+
+	lock_sock(sk);
+	if (!sk->sk_shutdown) {
+		if (l2cap_pi(sk)->mode == L2CAP_MODE_ERTM)
+			err = __l2cap_wait_ack(sk);
+
+		sk->sk_shutdown = SHUTDOWN_MASK;
+		l2cap_sock_clear_timer(sk);
+		__l2cap_sock_close(sk, 0);
+
+		if (sock_flag(sk, SOCK_LINGER) && sk->sk_lingertime)
+			err = bt_sock_wait_state(sk, BT_CLOSED,
+							sk->sk_lingertime);
+	}
+
+	if (!err && sk->sk_err)
+		err = -sk->sk_err;
+
+	release_sock(sk);
+	return err;
+}
+
 static int l2cap_sock_release(struct socket *sock)
 {
 	struct sock *sk = sock->sk;
-- 
1.7.4.rc3


  reply	other threads:[~2011-02-04  6:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-04  6:01 [bluetooth-next 00/16] l2cap.c split Gustavo F. Padovan
     [not found] ` <1296799318-5517-2-git-send-email-padovan@profusion.mobi>
2011-02-04  6:01   ` [bluetooth-next 02/16] Bluetooth: Initial work for L2CAP split Gustavo F. Padovan
2011-02-04  6:01     ` [bluetooth-next 03/16] Bluetooth: move l2cap_sock_ops to l2cap_sock.c Gustavo F. Padovan
2011-02-04  6:01       ` [bluetooth-next 04/16] Bluetooth: move l2cap_sock_release() " Gustavo F. Padovan
2011-02-04  6:01         ` [bluetooth-next 05/16] Bluetooth: move l2cap_sock_bind()/listen() " Gustavo F. Padovan
2011-02-04  6:01           ` [bluetooth-next 06/16] Bluetooth: move l2cap_sock_accept() " Gustavo F. Padovan
2011-02-04  6:01             ` [bluetooth-next 07/16] Bluetooth: move l2cap_sock_getname() " Gustavo F. Padovan
2011-02-04  6:01               ` [bluetooth-next 08/16] Bluetooth: move l2cap_sock_setsockopt() " Gustavo F. Padovan
2011-02-04  6:01                 ` [bluetooth-next 09/16] Bluetooth: move l2cap_sock_getsockopt() " Gustavo F. Padovan
2011-02-04  6:01                   ` [bluetooth-next 10/16] Bluetooth: move l2cap_sock_connect() " Gustavo F. Padovan
2011-02-04  6:01                     ` [bluetooth-next 11/16] Bluetooth: move l2cap_sock_recvmsg() " Gustavo F. Padovan
2011-02-04  6:01                       ` Gustavo F. Padovan [this message]
2011-02-04  6:01                         ` [bluetooth-next 13/16] Bluetooth: move l2cap_sock_sendmsg() " Gustavo F. Padovan
2011-02-04  6:01                           ` [bluetooth-next 14/16] Bluetooth: move L2CAP sock timers function " Gustavo F. Padovan
2011-02-04  6:01                             ` [bluetooth-next 15/16] Bluetooth: move l2cap_sock_kill() " Gustavo F. Padovan
2011-02-04  6:01                               ` [bluetooth-next 16/16] Bluetooth: move __l2cap_sock_close() " Gustavo F. Padovan
2011-02-04 12:38 ` [bluetooth-next 00/16] l2cap.c split Luiz Augusto von Dentz
2011-02-04 13:44   ` Gustavo F. Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296799318-5517-13-git-send-email-padovan@profusion.mobi \
    --to=padovan@profusion.mobi \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).