From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Cc: Anderson Lizardo <anderson.lizardo@openbossa.org>
Subject: [PATCH] Fix DBG() calls with bogus messages
Date: Wed, 23 Feb 2011 15:11:03 -0300 [thread overview]
Message-ID: <1298484663-19369-1-git-send-email-anderson.lizardo@openbossa.org> (raw)
In-Reply-To: <1298467707-11121-1-git-send-email-anderson.lizardo@openbossa.org>
Remove unnecessary trailing newlines (already added by DBG()) and
rewrite debug messages to become more useful.
---
audio/telephony-ofono.c | 2 +-
plugins/service.c | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/audio/telephony-ofono.c b/audio/telephony-ofono.c
index 0a7f0bd..ef4ede7 100644
--- a/audio/telephony-ofono.c
+++ b/audio/telephony-ofono.c
@@ -1116,7 +1116,7 @@ static void get_modems_reply(DBusPendingCall *call, void *user_data)
DBusMessage *reply;
DBusMessageIter iter, entry;
- DBG("list_modem_reply is called\n");
+ DBG("");
reply = dbus_pending_call_steal_reply(call);
dbus_error_init(&err);
diff --git a/plugins/service.c b/plugins/service.c
index f44aa92..d73cdea 100644
--- a/plugins/service.c
+++ b/plugins/service.c
@@ -172,13 +172,14 @@ static void element_end(GMarkupParseContext *context,
int ret = sdp_attr_add(ctx_data->record, ctx_data->attr_id,
ctx_data->stack_head->data);
if (ret == -1)
- DBG("Trouble adding attribute\n");
+ DBG("Could not add attribute 0x%04x",
+ ctx_data->attr_id);
ctx_data->stack_head->data = NULL;
sdp_xml_data_free(ctx_data->stack_head);
ctx_data->stack_head = NULL;
} else {
- DBG("No data for attribute 0x%04x\n", ctx_data->attr_id);
+ DBG("No data for attribute 0x%04x", ctx_data->attr_id);
}
return;
}
--
1.7.0.4
next prev parent reply other threads:[~2011-02-23 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 13:28 [PATCH] Drop trailing newline from DBG() calls Anderson Lizardo
2011-02-23 18:11 ` Anderson Lizardo [this message]
2011-02-24 18:28 ` [PATCH] Fix DBG() calls with bogus messages Johan Hedberg
2011-02-23 18:12 ` [PATCH] Drop trailing newline from DBG() calls Anderson Lizardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298484663-19369-1-git-send-email-anderson.lizardo@openbossa.org \
--to=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox