From: Dmitriy Paliy <dmitriy.paliy@nokia.com>
To: linux-bluetooth@vger.kernel.org
Cc: Dmitriy Paliy <dmitriy.paliy@nokia.com>
Subject: [PATCH 2/3] Change dial and re-dial in maemo6 telephony
Date: Tue, 15 Mar 2011 14:55:53 +0200 [thread overview]
Message-ID: <1300193754-5748-2-git-send-email-dmitriy.paliy@nokia.com> (raw)
In-Reply-To: <1300193754-5748-1-git-send-email-dmitriy.paliy@nokia.com>
Dial and re-dial to last number functions are changed in maemo6
telephony driver accordingly to updated API in csd back-end. CreateWith
method call is replaced by Create and CreateFromLast.
After such modification callerid and last dialed number are not used
and hence removed in sucessive patch.
---
audio/telephony-maemo6.c | 27 ++++++++++++++-------------
1 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/audio/telephony-maemo6.c b/audio/telephony-maemo6.c
index 04c69c6..311b5ed 100644
--- a/audio/telephony-maemo6.c
+++ b/audio/telephony-maemo6.c
@@ -579,14 +579,19 @@ static int send_method_call(const char *dest, const char *path,
void telephony_last_dialed_number_req(void *telephony_device)
{
+ int ret;
+
DBG("telephony-maemo6: last dialed number request");
- if (last_dialed_number)
- telephony_dial_number_req(telephony_device,
- last_dialed_number);
+ ret = send_method_call(CSD_CALL_BUS_NAME, CSD_CALL_PATH,
+ CSD_CALL_INTERFACE, "CreateFromLast",
+ NULL, NULL,
+ DBUS_TYPE_INVALID);
+ if (ret < 0)
+ telephony_dial_number_rsp(telephony_device,
+ CME_ERROR_AG_FAILURE);
else
- telephony_last_dialed_number_rsp(telephony_device,
- CME_ERROR_NOT_ALLOWED);
+ telephony_dial_number_rsp(telephony_device, CME_ERROR_NONE);
}
static const char *memory_dial_lookup(int location)
@@ -599,18 +604,15 @@ static const char *memory_dial_lookup(int location)
void telephony_dial_number_req(void *telephony_device, const char *number)
{
- uint32_t flags = callerid;
int ret;
DBG("telephony-maemo6: dial request to %s", number);
- if (strncmp(number, "*31#", 4) == 0) {
+ if (strncmp(number, "*31#", 4) == 0)
number += 4;
- flags = CALL_FLAG_PRESENTATION_ALLOWED;
- } else if (strncmp(number, "#31#", 4) == 0) {
+ else if (strncmp(number, "#31#", 4) == 0)
number += 4;
- flags = CALL_FLAG_PRESENTATION_RESTRICTED;
- } else if (number[0] == '>') {
+ else if (number[0] == '>') {
const char *location = &number[1];
number = memory_dial_lookup(strtol(&number[1], NULL, 0));
@@ -623,10 +625,9 @@ void telephony_dial_number_req(void *telephony_device, const char *number)
}
ret = send_method_call(CSD_CALL_BUS_NAME, CSD_CALL_PATH,
- CSD_CALL_INTERFACE, "CreateWith",
+ CSD_CALL_INTERFACE, "Create",
NULL, NULL,
DBUS_TYPE_STRING, &number,
- DBUS_TYPE_UINT32, &flags,
DBUS_TYPE_INVALID);
if (ret < 0) {
telephony_dial_number_rsp(telephony_device,
--
1.7.1
next prev parent reply other threads:[~2011-03-15 12:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 12:55 [PATCH 1/3] Move telephony_last_dialed_number_req Dmitriy Paliy
2011-03-15 12:55 ` Dmitriy Paliy [this message]
2011-03-15 12:55 ` [PATCH 3/3] Remove unused code due to dial and re-dial change Dmitriy Paliy
2011-03-15 17:36 ` [PATCH 1/3] Move telephony_last_dialed_number_req Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300193754-5748-2-git-send-email-dmitriy.paliy@nokia.com \
--to=dmitriy.paliy@nokia.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox