Linux bluetooth development
 help / color / mirror / Atom feed
From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Cc: Anderson Lizardo <anderson.lizardo@openbossa.org>
Subject: [PATCH 15/15] GATT server: add disconnect watch
Date: Wed, 16 Mar 2011 21:00:39 -0400	[thread overview]
Message-ID: <1300323639-13296-16-git-send-email-anderson.lizardo@openbossa.org> (raw)
In-Reply-To: <1300323639-13296-1-git-send-email-anderson.lizardo@openbossa.org>

The disconnect watch is used to delete attributes added by a client. The
added attributes are only useful while the D-Bus client which added them
is alive, otherwise read/write callbacks, notifications and indications
will not work.
---
 plugins/gatt-profile.c |   64 +++++++++++++++++++++++++++++++++++++++++++----
 1 files changed, 58 insertions(+), 6 deletions(-)

diff --git a/plugins/gatt-profile.c b/plugins/gatt-profile.c
index 521befe..600efa1 100644
--- a/plugins/gatt-profile.c
+++ b/plugins/gatt-profile.c
@@ -44,6 +44,11 @@
 static DBusConnection *connection = NULL;
 static const char *any_path = NULL;
 
+struct client_data {
+	GSList *attrs; /* All attributes registered by this client */
+	guint listener_id;
+};
+
 struct gatt_descriptor {
 	uint16_t type;
 	union {
@@ -568,6 +573,7 @@ static void register_services(gpointer data, gpointer user_data)
 static void free_services(gpointer data, gpointer user_data)
 {
 	struct gatt_service *svc = data;
+	GSList **attrs = user_data;
 	GSList *cl;
 
 	for (cl = svc->chars; cl; cl = cl->next) {
@@ -593,6 +599,9 @@ static void free_services(gpointer data, gpointer user_data)
 	g_free(svc->id);
 	g_slist_free(svc->includes);
 
+	if (attrs)
+		*attrs = g_slist_concat(*attrs, svc->attrs);
+
 	g_free(svc);
 }
 
@@ -639,7 +648,8 @@ static void update_includes(gpointer data, gpointer user_data)
 	}
 }
 
-static int add_xml_profile(DBusConnection *conn, const char *profile)
+static int add_xml_profile(DBusConnection *conn, const char *profile,
+								GSList **attrs)
 {
 	GMarkupParser parser = { element_start, element_end, NULL, NULL, NULL };
 	GMarkupParseContext *ctx;
@@ -656,7 +666,7 @@ static int add_xml_profile(DBusConnection *conn, const char *profile)
 	g_slist_foreach(services, resolve_includes, services);
 	g_slist_foreach(services, register_services, NULL);
 	g_slist_foreach(services, update_includes, NULL);
-	g_slist_foreach(services, free_services, NULL);
+	g_slist_foreach(services, free_services, attrs);
 	g_slist_free(services);
 
 	g_markup_parse_context_free(ctx);
@@ -664,23 +674,59 @@ static int add_xml_profile(DBusConnection *conn, const char *profile)
 	return ret;
 }
 
+static void exit_callback(DBusConnection *conn, void *user_data)
+{
+	struct client_data *client = user_data;
+	GSList *l;
+
+	DBG("client=%p", client);
+
+	for (l = client->attrs; l; l = l->next) {
+		struct attribute *a = l->data;
+
+		attrib_db_del(a->handle);
+	}
+
+	g_slist_free(client->attrs);
+	client->attrs = NULL;
+}
+
 static DBusMessage *add_profile(DBusConnection *conn, DBusMessage *msg,
 								void *user_data)
 {
-	const char *profile;
+	struct client_data *client = user_data;
+	const char *sender, *profile;
 	int err;
 
 	if (!dbus_message_get_args(msg, NULL, DBUS_TYPE_STRING, &profile,
 							DBUS_TYPE_INVALID))
 		return NULL;
 
-	err = add_xml_profile(conn, profile);
+	err = add_xml_profile(conn, profile, &client->attrs);
 	if (err < 0)
 		return btd_error_failed(msg, strerror(-err));
 
+	sender = dbus_message_get_sender(msg);
+	client->listener_id = g_dbus_add_disconnect_watch(conn, sender,
+					exit_callback, client, NULL);
+
+	DBG("listener_id %d", client->listener_id);
+
 	return dbus_message_new_method_return(msg);
 }
 
+static void destroy_interface(void *user_data)
+{
+	struct client_data *client = user_data;
+
+	DBG("client=%p", client);
+
+	g_dbus_remove_watch(connection, client->listener_id);
+	exit_callback(connection, client);
+
+	g_free(client);
+}
+
 static GDBusMethodTable gatt_profile_methods[] = {
 	{ "AddProfile", "s", "", add_profile },
 	{ }
@@ -688,13 +734,19 @@ static GDBusMethodTable gatt_profile_methods[] = {
 
 static int register_interface(const char *path, struct btd_adapter *adapter)
 {
+	struct client_data *client;
+
 	DBG("path %s", path);
 
+	client = g_new0(struct client_data, 1);
+
 	if (!g_dbus_register_interface(connection, path, GATT_PROFILE_INTERFACE,
-					gatt_profile_methods, NULL, NULL, NULL,
-					NULL)) {
+					gatt_profile_methods, NULL, NULL,
+					client, destroy_interface)) {
 		error("D-Bus failed to register %s interface",
 							GATT_PROFILE_INTERFACE);
+		g_free(client);
+
 		return -EIO;
 	}
 
-- 
1.7.0.4


      parent reply	other threads:[~2011-03-17  1:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17  1:00 [RFC][PATCH 00/15] Attribute server management API Anderson Lizardo
2011-03-17  1:00 ` [PATCH 01/15] Remove built-in example attribute server Anderson Lizardo
2011-03-17  1:00 ` [PATCH 02/15] GATT server: add profile API plugin skeleton Anderson Lizardo
2011-03-17  1:00 ` [PATCH 03/15] GATT server: add initial D-Bus interface Anderson Lizardo
2011-03-17  1:00 ` [PATCH 04/15] GATT server: add initial XML parsing Anderson Lizardo
2011-03-17  1:00 ` [PATCH 05/15] GATT server: parse primary/secondary services Anderson Lizardo
2011-03-17  1:00 ` [PATCH 06/15] GATT server: parse and resolve service includes Anderson Lizardo
2011-03-17  1:00 ` [PATCH 07/15] GATT server: parse characteristics Anderson Lizardo
2011-03-17  1:00 ` [PATCH 08/15] GATT server: parse characteristic value Anderson Lizardo
2011-03-17  1:00 ` [PATCH 09/15] GATT server: add test/test-gatt-profile example Anderson Lizardo
2011-03-17  1:00 ` [PATCH 10/15] Add attrib_db_find_avail() function to attribute server Anderson Lizardo
2011-03-17  1:00 ` [PATCH 11/15] GATT server: add service registration Anderson Lizardo
2011-03-17  1:00 ` [PATCH 12/15] GATT server: add service includes registration Anderson Lizardo
2011-03-17  1:00 ` [PATCH 13/15] GATT server: add characteristic registration Anderson Lizardo
2011-03-17  1:00 ` [PATCH 14/15] GATT server: add characteristic descriptor registration Anderson Lizardo
2011-03-17  1:00 ` Anderson Lizardo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300323639-13296-16-git-send-email-anderson.lizardo@openbossa.org \
    --to=anderson.lizardo@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox